Re: [PATCH 4/4] regulator: Add support for UGREEN NASync DH2300 MCU SATA power gate

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The platform driver lacks a MODULE_ALIAS() declaration, which prevents automatic module loading.
--

commit 64ccd270dc21c4fa03f9ebc2bb443018b396eeab
Author: Alexey Charkov <alchark@flipper.net>

regulator: Add support for UGREEN NASync DH2300 MCU SATA power gate

This commit adds a driver for the SATA drive-bay power gate function of the
UGREEN NASync DH2300 embedded controller. It acts as a simple on/off regulator
controlled by register 0x41.

> diff --git a/drivers/regulator/ugreen-dh2300-mcu-regulator.c b/drivers/regulator/ugreen-dh2300-mcu-regulator.c
> new file mode 100644
> index 0000000000000..69fda90f7ace6
> --- /dev/null
> +++ b/drivers/regulator/ugreen-dh2300-mcu-regulator.c

[ ... ]

> +static struct platform_driver ugreen_dh2300_mcu_regulator_driver = {
> +	.driver = {
> +		.name = "ugreen-dh2300-mcu-regulator",
> +	},
> +	.probe = ugreen_dh2300_mcu_regulator_probe,
> +};
> +module_platform_driver(ugreen_dh2300_mcu_regulator_driver);
> +
> +MODULE_DESCRIPTION("UGREEN NASync DH2300 MCU SATA power regulator");
> +MODULE_LICENSE("GPL");

[Severity: Medium]
Will ugreen_dh2300_mcu_regulator_driver load automatically when built as a
module?

This driver lacks an id_table, of_match_table, or a MODULE_ALIAS declaration.
When the MFD core registers the sub-device, the platform bus emits a uevent
with MODALIAS=platform:ugreen-dh2300-mcu-regulator.

Without the alias mapping, udev/modprobe might fail to automatically load
the driver on boot, leaving the SATA drives unpowered unless the module
is manually loaded.

Would it make sense to add MODULE_ALIAS("platform:ugreen-dh2300-mcu-regulator")?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260612-dh2300-mcu-v1-0-ab8db1617bc0@flipper.net?part=4