From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5038B403EA2 for ; Fri, 12 Jun 2026 17:36:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781285795; cv=none; b=RbOQhA3PRZBLvQbBcXBI2fbHvjg5Ov0bJtWSjf5KtDxXxRPDd4U85ASK5jFOc2lIMmwC3B5W1/FDUqHh2KYfx62NALwg6QMMOgq6d+x7WxbQBQ25iyqxKZrjeTtjkuHwWZCG3HHsRHJ2EMq3Y834KcrU/Qd8+V2GMGf0GGhi3Ak= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781285795; c=relaxed/simple; bh=d8eHlCMrkwu1cSGEFfHyF2YBC3fX1z3CiN5d6K0gPTA=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=Lv+7W5fxAYQG6pnlCEVPc6uO375y2dE8xa9uzcVLJl/dgBG1zRalawxJHIlw07O0Wq65NSgBS2NoY1ZcoTsp2GueY01AOYU9zDBeZ+m3HLMcfGKXc26Au+Zka0Jjv9Ole2eCT0/Djw3KPmB9y7wOWSDj80IOw7GhUE6jXPXDmK8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=eD0cbThO; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eD0cbThO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D5A5E1F000E9; Fri, 12 Jun 2026 17:36:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781285794; bh=q+QKyffejTA0Siagoa2psHa78z7Xv2JYlb2GSFKS7lk=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=eD0cbThOMxhPRQgy1d99+sh2PK4obr+UhJ9axf0IY3MvZkld6Jj3k717N3kOMUod3 0j7ndw/RbB3hUdzHkY0Mkk2zfsAKDpSpeXJdNe8Tllepi0FPz2yJ/LwfvKG3ZMC93g P8S+vC7zk7KscpPXv0QR6heMrfXdlG2PHp590JTInZ8BgWI/JOFwTdCkxHQL7hKtxA P0qqqgu+76F+WDKFor3dRIgwiJ5RBTDsdHtUgwpDbuITOLNKhtHrqi9hCEtli8v1t4 t8Th7VfnEiWYNwjFhBd7d1C6RibgIcGLFlwFl4acpydjUZaZiEU/wDw6Ie5QoVVJ7b AsUuvXDaoGRZA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v6 5/5] arm64: dts: qcom: Add Shikra EVK boards Reply-To: sashiko-reviews@lists.linux.dev To: "Komal Bajaj" Cc: robh@kernel.org, vkoul@kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, neil.armstrong@linaro.org, conor+dt@kernel.org, olteanv@gmail.com In-Reply-To: <20260612-shikra-dt-v6-5-6b6cb58db477@oss.qualcomm.com> References: <20260612-shikra-dt-v6-5-6b6cb58db477@oss.qualcomm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 12 Jun 2026 17:36:33 +0000 Message-Id: <20260612173633.D5A5E1F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] `shikra-cqs-evk.dts` incorrectly includes `shikra-cqm-som.dtsi` = instead of a CQS-specific SoM file. -- commit 0c4f6d07dd3b32da53231a5dcf3de036bb58f76f Author: Komal Bajaj arm64: dts: qcom: Add Shikra EVK boards This commit adds device trees for the Shikra EVK platform, introducing three board variants paired with a common carrier board. It includes configurations for retail and industrial SoMs, both with and without modems. [ ... ] > diff --git a/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts b/arch/arm64/boo= t/dts/qcom/shikra-cqs-evk.dts > new file mode 100644 > index 0000000000000..b3f19a64d7aed > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts > @@ -0,0 +1,40 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* > + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. > + */ > + > +/dts-v1/; > + > +#include "shikra-cqm-som.dtsi" [Severity: Medium] Is this the intended include for the CQS board? The commit message indicates the CQS board pairs with the CQ2390S SoM=20 (without modem), but this includes the CQM (with modem) SoM definition. If modem-specific nodes are later added to shikra-cqm-som.dtsi, wouldn't they inadvertently be applied to this modem-less CQS variant? > +#include "shikra-evk.dtsi" > + > +/ { > + model =3D "Qualcomm Technologies, Inc. Shikra CQS EVK"; > + compatible =3D "qcom,shikra-cqs-evk", "qcom,shikra-cqs-som", "qcom,shik= ra"; [ ... ] --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260612-shikra-dt-= v6-0-6b6cb58db477@oss.qualcomm.com?part=3D5