Re: [PATCH] dt-bindings: pwm: st,pwm: convert to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `interrupts` property is unconditionally required by the driver but omitted from the YAML schema's required list.
--

commit b16a62dff3236ec8b123a99775f6c90dbfd9912f
Author: Charan Pedumuru <charan.pedumuru@gmail.com>

dt-bindings: pwm: st,pwm: convert to DT schema

Convert STMicroelectronics STiH41x PWM/Capture controller binding
to DT schema.

> diff --git a/Documentation/devicetree/bindings/pwm/pwm-st.txt b/Documentation/devicetree/bindings/pwm/pwm-st.txt
> deleted file mode 100644
> index 19fce774cafad..0000000000000
> --- a/Documentation/devicetree/bindings/pwm/pwm-st.txt
> +++ /dev/null

[ ... ]

> -Required parameters:

[ ... ]

> -- interrupts:		IRQ for the Capture device

[ ... ]

> diff --git a/Documentation/devicetree/bindings/pwm/st,pwm.yaml b/Documentation/devicetree/bindings/pwm/st,pwm.yaml
> new file mode 100644
> index 0000000000000..2c10f54b5caf3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/st,pwm.yaml

[ ... ]

> +required:
> +  - reg
> +  - compatible
> +  - "#pwm-cells"
> +  - pinctrl-names
> +  - clock-names
> +  - clocks

[Severity: Medium]
Should interrupts be included in this required list?

The original text binding listed interrupts under the required parameters,
and the driver unconditionally requests it during probe:

drivers/pwm/pwm-sti.c:sti_pwm_probe() {
    ...
    irq = platform_get_irq(pdev, 0);
    if (irq < 0)
        return irq;

    ret = devm_request_irq(&pdev->dev, irq, sti_pwm_interrupt, 0,
                           pdev->name, pc);
    ...
}

Without interrupts in the required list, incomplete device trees will pass
schema validation but fail deterministically at runtime.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260613-st-pwm-v1-1-458c2c89709a@gmail.com?part=1