From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E82131DDBB for ; Sat, 13 Jun 2026 09:48:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781344126; cv=none; b=Ye0UwN9IZFoEB4lKTSC3h3ko8dIezCEn6xPjvxINNR69EQpKnCK+ixogSHDptYhSEVIr5S4w8DVqK2fb5WK+XbD+kWjH5tXGBTtn11ztJaEUOk11c8HK4svHf3GGaByewl3GIuXnWhTLNDES8PmZpw6uSeMbto9NG7vQKmhk2uo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781344126; c=relaxed/simple; bh=Le2TluI4QhioSProWh/T+ChT6gMlyKD/CDA5Y/Z4G2Y=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=UViGzseMwrUpmNaVnacKehDEhwYmdnxPM/qj2fPvCv6WVJiH5HC89FQirrN/As7B6bqmpbKDmZOyrQ0UJvizmaCWf++rTyT0EvyQ7gfghtYOMFTohJt/vtjMkcipVII41Z+Tin4MBdU4Sj3vQ/opAyIJMLjz72r18TXAgE5y25M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bXm0O7zi; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bXm0O7zi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EEA7D1F000E9; Sat, 13 Jun 2026 09:48:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781344125; bh=H0vp+trOASQuyJmUUNeuT7uAJO9F68Wif0rAf01Dmbs=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=bXm0O7zi7j4K84kkiWJyCEvL0Vyn2p9LdJIq+FshdLqRQ5twCcgF0hk2jLN7yRCO8 zoxx6xe2VEQf/9ODokIMC9ovsMzPrmMqhH8hIDuA7XL/xLM0kcN2Mt7/LPfXOeMx/W Je+QcsmBN0IXkXR99xp0UASWF2pkA7hTZslonTjHV7WU7Ko8Coh51oDjGDy+908yy/ l3YMCdKWKK6XOus92sb9yHOvueujnONAYLKDfO6mBht4SkvgjRCKexaLrMh6sFj91j 4qs7c68b2Wq2llO+9e7CpIqizYsNJ6x6uLnutgBH/NtpP34I7hw67Fazr0s5zVcDAG VMWaa7nDnYRAw== From: sashiko-bot@kernel.org Subject: Re: [PATCH v4 1/2] arm: dts: st: align node patterns with established convention Reply-To: sashiko-reviews@lists.linux.dev To: "Charan Pedumuru" Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org In-Reply-To: <20260613-st-mmc-v4-1-b3c385617c16@gmail.com> References: <20260613-st-mmc-v4-1-b3c385617c16@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Sat, 13 Jun 2026 09:48:44 +0000 Message-Id: <20260613094844.EEA7D1F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [High] Renaming 'sdhci@...' nodes to 'mmc@...' in the base dtsi file leav= es overrides in derived dtsi and dts files orphaned, causing node duplicati= on and completely breaking MMC functionality. -- commit 40b6fa41749cf01adbee4227ca47061d9fbb6688 Author: Charan Pedumuru arm: dts: st: align node patterns with established convention This commit updates ST MMC DTS node patterns to match established convention by renaming the base sdhci nodes to mmc. > diff --git a/arch/arm/boot/dts/st/stih407-family.dtsi b/arch/arm/boot/dts= /st/stih407-family.dtsi > index 3e6a0542e3aea..08acba209c564 100644 > --- a/arch/arm/boot/dts/st/stih407-family.dtsi > +++ b/arch/arm/boot/dts/st/stih407-family.dtsi > @@ -596,7 +596,7 @@ spi@9542000 { > status =3D "disabled"; > }; > =20 > - mmc0: sdhci@9060000 { > + mmc0: mmc@9060000 { [Severity: High] Does renaming these base nodes to mmc@... leave downstream overrides orphaned? Looking at board files like arch/arm/boot/dts/st/stih410-b2260.dts and arch/arm/boot/dts/st/stih418-b2199.dts, there are still overrides using the old names: mmc0: sdhci@9060000 { pinctrl-0 =3D <&pinctrl_sd0>; bus-width =3D <4>; status =3D "okay"; }; Because the base node is renamed here without updating the downstream files, will the DTC compiler treat the downstream overrides as new node declaratio= ns rather than property merges? This would leave the base mmc@9060000 node disabled, while the new sdhci@9060000 node would lack essential properties like compatible and reg, preventing the kernel from binding the MMC driver to the hardware. > compatible =3D "st,sdhci-stih407", "st,sdhci"; > status =3D "disabled"; > reg =3D <0x09060000 0x7ff>, <0x9061008 0x20>; [ ... ] > - mmc1: sdhci@9080000 { > + mmc1: mmc@9080000 { [Severity: High] Are there similar orphaned overrides for this node? Checking arch/arm/boot/dts/st/stih418-b2199.dts, it appears this node is also overridden using the old name: mmc1: sdhci@9080000 { status =3D "okay"; }; Would this result in the same missing compatible properties and disabled base node? > compatible =3D "st,sdhci-stih407", "st,sdhci"; > status =3D "disabled"; > reg =3D <0x09080000 0x7ff>; --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260613-st-mmc-v4-= 0-b3c385617c16@gmail.com?part=3D1