Re: [PATCH 3/4] arm64: dts: allwinner: add Allwinner A733 SoC

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The patch references missing header files for CCU clock and reset bindings, which will cause a build failure.
- [Low] New compatible strings for the CCU and pinctrl are used without being documented in the YAML schemas.
--

commit 08b3c222d5fc2b42b4c8ea3dd602ebcc113d5545
Author: Enzo Adriano <enzo.adriano.code@gmail.com>

arm64: dts: allwinner: add Allwinner A733 SoC

Add the initial A733 SoC description with CPUs, timers, interrupt
controller, clocks, pinctrl, UART0, and MMC0.

Keep peripherals disabled by default. Board DTS files can enable only the
devices that are proven on their hardware.

> diff --git a/arch/arm64/boot/dts/allwinner/sun60i-a733.dtsi b/arch/arm64/boot/dts/allwinner/sun60i-a733.dtsi
> new file mode 100644
> --- /dev/null
> +++ b/arch/arm64/boot/dts/allwinner/sun60i-a733.dtsi
> @@ -0,0 +1,198 @@
> +// SPDX-License-Identifier: (GPL-2.0-only OR MIT)
> +
> +#include <dt-bindings/interrupt-controller/arm-gic.h>
> +#include <dt-bindings/clock/sun60i-a733-ccu.h>
> +#include <dt-bindings/reset/sun60i-a733-ccu.h>

[Severity: Low]
Are these header files introduced in a different patch? Compiling this device
tree will fail at the preprocessor stage because these headers are missing
from the baseline tree and aren't added in this patch.

[ ... ]

> +		pio: pinctrl@2000000 {
> +			compatible = "allwinner,sun60i-a733-pinctrl";

[Severity: Low]
Are these new compatible strings documented in the dt-binding YAML schemas?
Adding new compatibles without their corresponding binding documentation will
trigger make dtbs_check warnings.

> +			reg = <0x02000000 0x600>;

[ ... ]

> +		ccu: clock-controller@2002000 {
> +			compatible = "allwinner,sun60i-a733-ccu";

[Severity: Low]
Will this compatible string also need to be added to the YAML schemas to
avoid validation warnings?

> +			reg = <0x02002000 0x2000>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260613-a733-dts-v1-public-ready-v1-0-7787c94681db@gmail.com?part=3