From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0E983C2785; Sat, 13 Jun 2026 11:18:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781349505; cv=none; b=nSM1Me7zbon7gtzujSKwFKQ8rroedMlMMQfMeDt0ebdogk9pjT+qmyyrFo4LhoQyl/CLbV/rvw9r/GRmbpAQwghbk1iAKk7jbXUhBs8TZnXls0Ne8YnZ4sTJyGb6GS5vIScswhOQcbdrvg7uURyI2oJaQMYGyHnv8C3peAEYZMY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781349505; c=relaxed/simple; bh=qjUt5noLJcd9bZBDjBWj8429oMGahVQvlnNBuHYl0I4=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=RknZF9rR+BXZAIBDR8gReEXmQrRPatlKlXbv3M7vYwzeLv0YynpVtFprQocx1jbfPesz46z3Q0Iq4x2PmSjbYNPAoJlQnmB7Dk+FF8D+0OP0iGHTzr/l2ZeFEPiN0vfH19Ww5OnELRd9Nx+ik5vYyjoSE5rukVjmgjvNtsXpc54= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=anX5Z0Zk; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="anX5Z0Zk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C1CD51F000E9; Sat, 13 Jun 2026 11:18:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781349503; bh=z1nYbXXlvUfr1yVNSjzxIUDDwldykPyIZt4b1gAE89w=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=anX5Z0ZkDGi2N/ZrlfPOyoh3Su3hFOhqV8893VFTAyPijJeLty+4cwrYhF55wNg+q 8AoZN2jbACU1iP80agGMkapzQWyaqIB2LKa2gyy09wwOFgbeQrcQTOG0reKn5sQ1mu n+qlNDalGzxmj004R2hKaUIzfO0wq+O/PLMJKPBhacQF4ftGn7ufQNX4QTyCBFid0E FgJZyqgh6uE1R3SAjMHQ0jAbnP8Y/7XNi+psWGj+DoEM0ILy04bchQrxUTe1dckCiY 7aikqoDadii+H77iZPydUc9DGe1yjdw2qt+3gfrF25cxxcU9ZNTe8UL/YaJXITqiF7 hBS74D7S5E03w== Date: Sat, 13 Jun 2026 12:18:15 +0100 From: Jonathan Cameron To: Sirat Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] dt-bindings: iio: magnetometer: add QST QMC5883L Sensor Message-ID: <20260613121815.09b18d3a@jic23-huawei> In-Reply-To: References: <20260612124557.13750-1-email@sirat.me> <20260612124557.13750-3-email@sirat.me> <20260612173013.64f435ab@jic23-huawei> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sat, 13 Jun 2026 14:57:42 +0600 Sirat wrote: > On Fri, Jun 12, 2026 at 10:30=E2=80=AFPM Jonathan Cameron wrote: > > > > On Fri, 12 Jun 2026 18:45:26 +0600 > > Siratul Islam wrote: > > =20 > > > Add devicetree binding for the QST QMC5883L 3-Axis Magnetic Sensor > > > connected via i2c. > > > Interrupt not implemented in driver but kept in the binding for future > > > addition. =20 > > No need to mention that =20 > Got it. In the past I was advised to mention certain choices in the > commit message. I am still looking for the balance. Sure. Generally dt-bindings should never mention the driver. Despite being in the kernel tree they are not tightly coupled with the drivers and indeed are pulled into other projects. Jonathan > > > > The rest looks good to me. > > > > Thanks, > > > > Jonathan > > =20 > Thanks > Sirat