Re: [PATCH v7 5/5] iio: adc: versal-sysmon: add oversampling support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Software cache for oversampling ratio is not synchronized with hardware state.
--

commit 10aa21fe8c20849d9568e9f27df70f27c183249f
Author: Salih Erim <salih.erim@amd.com>

iio: adc: versal-sysmon: add oversampling support

Add support for reading and writing the oversampling ratio through
the IIO oversampling_ratio attribute. The hardware supports averaging
2, 4, 8, or 16 samples, plus a ratio of 1 (no averaging).

> diff --git a/drivers/iio/adc/versal-sysmon-core.c b/drivers/iio/adc/versal-sysmon-core.c
> index 16feb373bc704..d9599a7bc8978 100644
> --- a/drivers/iio/adc/versal-sysmon-core.c
> +++ b/drivers/iio/adc/versal-sysmon-core.c
[ ... ]
> @@ -839,6 +988,8 @@ int sysmon_core_probe(struct device *dev, struct regmap *regmap)
>  
>  	sysmon = iio_priv(indio_dev);
>  	sysmon->regmap = regmap;
> +	sysmon->temp_oversampling = 1;
> +	sysmon->supply_oversampling = 1;

[Severity: Medium]
Will this cause the software cache to be out of sync with the hardware if the
bootloader or firmware previously enabled oversampling?

Since these defaults are not written to the hardware registers during probe,
and the actual hardware state is not read back to populate the cache, the IIO
sysfs interface might incorrectly report a ratio of 1 while the hardware is
actually averaging samples.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260614233722.2603459-1-salih.erim@amd.com?part=5