From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5107D279334 for ; Mon, 15 Jun 2026 05:58:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781503138; cv=none; b=d8wDyBSMHbIorSnNl3XS4ieIJwk4qV+jyx+iqsB4v+kQ+j/CU76LNYz64tK3c0dlCjyDbyBHAX418QBeMoWDx6YkKrKoBPfIfSH4ExvfOq4MO/w1m0MLIabi0dDax79Eeju5BJU4hKsiMBcNtaa7WURwRfbBXdk+NmJFOiD2TpM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781503138; c=relaxed/simple; bh=Pm4OyMAP61mA3mN4kSfp/jGpGMMPAUmftzYSHNt95bk=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=pR3TpsYHwsY+ZEMXibns0PMJXr/BHp85paUWMt02u181t8+Do+DPqTI3Zt7FTI0Ue3Sryb0S7QnUlFf7YUulmv7BNW9S16pbJryJGZoFKXj+xhh3xTvu0YMAAHDq4In/0hnyzRWIbwV7ARGwFQr1mROMId+laj1H7Llsggr23g4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=U1Ib6nLJ; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="U1Ib6nLJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C39D1F000E9; Mon, 15 Jun 2026 05:58:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781503137; bh=vSoFisx1yYAN5MrYKXbZPonPev23XeGsWoy2Yd+cYcw=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=U1Ib6nLJxfKxtrR+d0vjMge8pkriDFz4BTgjTB5iVxlvd1W6Ov6HmZAxNqufjBaK+ 1OMNxBSo2zfR+RcW8CYKbcTrDhvsk1qcXfqn/guXoCewcgTY4v64gtRCE5FZkeFxgi BVm4xgP0Tao4cwf/a1oNKdZo0lBNtoHiZumKCc9+nry2EhV/35DwY98HMKFyv6O5TE iSJmixVNWQEncHCyK66xA9mvh92vpOOwQAgc4WvxiDsPuQwrjY2p6uRtsES2G43vqm Ikf7hAUSnpDOlAFYFNwEKp2oRi6aeyA+7PuGcSrNk45pipeL5enkeLMhkUY1n5Eocb Fpu9IK8k9wGjA== From: sashiko-bot@kernel.org Subject: Re: [PATCH 1/3] dt-bindings: phy: nuvoton,ma35d1-usb2-phy: extend for dual-port OTG support Reply-To: sashiko-reviews@lists.linux.dev To: "Joey Lu" Cc: devicetree@vger.kernel.org, vkoul@kernel.org, robh@kernel.org, conor+dt@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com, linux-phy@lists.infradead.org In-Reply-To: <20260615054911.48821-2-a0987203069@gmail.com> References: <20260615054911.48821-2-a0987203069@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 15 Jun 2026 05:58:56 +0000 Message-Id: <20260615055856.8C39D1F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] The device tree example fails `dt_binding_check` validation due to = a unit address mismatch and violations of the parent reset controller schem= a. -- commit abaf23416a1205bdc22b4891ef46a49e088031a4 Author: Joey Lu dt-bindings: phy: nuvoton,ma35d1-usb2-phy: extend for dual-port OTG support This extends the Nuvoton MA35D1 USB2 PHY binding to support two ports (OTG and host-only). The PHY node becomes a child of the syscon node, and properties are updated to reflect the new architecture. > diff --git a/Documentation/devicetree/bindings/phy/nuvoton,ma35d1-usb2-ph= y.yaml b/Documentation/devicetree/bindings/phy/nuvoton,ma35d1-usb2-phy.yaml > --- a/Documentation/devicetree/bindings/phy/nuvoton,ma35d1-usb2-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/nuvoton,ma35d1-usb2-phy.yaml > @@ -8,38 +8,72 @@ title: Nuvoton MA35D1 USB2 phy [ ... ] > examples: > - | > - #include > + system-management@40460000 { > + compatible =3D "nuvoton,ma35d1-reset", "syscon", "simple-mfd"; > + reg =3D <0x0 0x40460000 0x0 0x200>; > + #reset-cells =3D <1>; > + #address-cells =3D <1>; > + #size-cells =3D <1>; > =20 > - usb_phy: usb-phy { > - compatible =3D "nuvoton,ma35d1-usb2-phy"; > - clocks =3D <&clk USBD_GATE>; > - nuvoton,sys =3D <&sys>; > - #phy-cells =3D <0>; > + usb-phy@60 { > + compatible =3D "nuvoton,ma35d1-usb2-phy"; > + reg =3D <0x60 0x14>; > + #phy-cells =3D <1>; > + }; > }; [Severity: Low] Will this example pass dt_binding_check validation? The schema for the parent node (nuvoton,ma35d1-reset.yaml) enforces additionalProperties: false and requires exactly two compatible items ("nuvoton,ma35d1-reset" and "syscon"). It does not permit child nodes, the "simple-mfd" compatible, or the #address-cells and #size-cells properties. Additionally, does the 4-cell reg array <0x0 0x40460000 0x0 0x200> mismatch the unit address @40460000? Without a ranges property, the dt-schema wrapper defaults to 1 cell for address and size, which parses this as two distinct ranges and triggers a dtc unit_address_vs_reg warning. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260615054911.4882= 1-1-a0987203069@gmail.com?part=3D1