From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C60F30D3FC for ; Mon, 15 Jun 2026 12:06:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781525194; cv=none; b=JQuLJW2ItclD6n30598Y/qvAe7oKxzmpyAS+7qGbz9dWK6HOjEOotEcqv8fXFh/J8cRs1/i1gF3YwyCY9zrje0FvjRnA1Wp6LEOZNWSsc/m5yTig1ICKrVP7E0KQfpv6qox8NZBBREm4ldWHeAhoDmExkj39yZT+E3P2sWVHeNk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781525194; c=relaxed/simple; bh=7KxcQnq/kHV5+ZnpJfQeayzbt4wk4kpjtDu+yu+7D8Q=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=QSMhnqMftEtuAbDZx9agJ+ixS7C0LXMwc4BYutR9+0zadl9zBAsVAF1ER1qG3geVYnjDGQ41F+Ctu3VY1UQQWbNNIYiJEerOU5YhCNNkq71O68uu4ZS6l5BQhw+kPCcSQ0UufiB2B++3JJ70Q2BoWw/7VUrnltH5gBX2omlMix8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YhZPfXnh; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YhZPfXnh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA7DE1F000E9; Mon, 15 Jun 2026 12:06:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781525193; bh=MLhxDtwRH3heymAa2jmGqJYEA1ns+JBxjPpvqn4LTUM=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=YhZPfXnhLA7Lr58TEf+xoqpJHNtihOcCZASAMV8kteJzc/uRdirAZnUjCFU9+Egjg wQ7uT+zBOYDV7wXwwGyTLA/QZLSCFoIdsmzW5BqDzJiNZDLuxIcS3hNhWZHFva6W1L GRzY0R6TbJbzEaZ0dLLoc3Ky9T4AdCEVhkhaCV0UE/ckTAxL859LTnyjgX1KHBLf8I vA0mxb0+q7K8SMXEZti4zEwG/6W7bhhZ7AGqffsBI2oAFmOpyWayhXaUoIxilhG8Vy bn2G204v5mGPgrVvtuGP2kEre+LFHrselbhZ2fXruwg/sbHdZpPBvBwjJBf1/F8ZBT cn7FmP7WvAsjQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2] spi: dt-bindings: microchip,pic32mzda-spi: Convert to DT schema Reply-To: sashiko-reviews@lists.linux.dev To: "Udaya Kiran Challa" Cc: conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org In-Reply-To: <20260615115311.515404-1-challauday369@gmail.com> References: <20260615115311.515404-1-challauday369@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 15 Jun 2026 12:06:32 +0000 Message-Id: <20260615120632.DA7DE1F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] The `cs-gpios` property was omitted from the `required` list dur= ing the DT schema conversion. -- commit 418415dcdca7e4f555bde32db4703c62c250ee78 Author: Udaya Kiran Challa spi: dt-bindings: microchip,pic32mzda-spi: Convert to DT schema Convert Microchip PIC32 SPI controller devicetree binding from legacy text format to DT schema. > diff --git a/Documentation/devicetree/bindings/spi/microchip,pic32mzda-sp= i.yaml b/Documentation/devicetree/bindings/spi/microchip,pic32mzda-spi.yaml > new file mode 100644 > index 0000000000000..a0a182cdccbd9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/spi/microchip,pic32mzda-spi.yaml [ ... ] > +required: > + - compatible > + - reg > + - interrupts > + - interrupt-names > + - clocks > + - clock-names > + > +unevaluatedProperties: false [Severity: Medium] Did this conversion intentionally drop cs-gpios from the required properties list? Looking at the legacy text binding being removed, cs-gpios was explicitly listed under the required properties section. Since the PIC32 SPI driver returns -EINVAL if the GPIO chip select is missing during setup, omitting it here might allow incomplete device trees to pass schema validation but fail later at probe time. Could we add cs-gpios back to the required list to maintain parity with the old binding constraints? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260615115311.5154= 04-1-challauday369@gmail.com?part=3D1