Re: [PATCH 2/4] arm64: dts: qcom: sc8180x-primus: Describe the display power net

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Typo in pinctrl node name: 'blw-pwr-en-state' instead of 'bl-pwr-en-state'.
--

commit 811dfdf2795d7b72d8bd9ca1c392faa696962302
Author: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

arm64: dts: qcom: sc8180x-primus: Describe the display power net

This commit describes and wires up the power supplies for the eDP panel and
its backlight. Previously, this was only working because of settings
inherited from the bootloader.

> diff --git a/arch/arm64/boot/dts/qcom/sc8180x-primus.dts b/arch/arm64/boot/dts/qcom/sc8180x-primus.dts
> index ffe7c45366ed4..ed4f7f10e3768 100644
> --- a/arch/arm64/boot/dts/qcom/sc8180x-primus.dts
> +++ b/arch/arm64/boot/dts/qcom/sc8180x-primus.dts

[ ... ]

> @@ -769,6 +803,12 @@ &wifi {
>  };
>  
>  /* PINCTRL */
> +&pmc8180_2_gpios {
> +	bl_pwr_en: blw-pwr-en-state {

[Severity: Low]
This isn't a bug, but there appears to be a typo in the pinctrl node name.
Should "blw-pwr-en-state" be "bl-pwr-en-state" to match the typical naming
conventions for backlight pin states?

> +		pins = "gpio1";
> +		function = "normal";
> +	};
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260615-topic-8180_disp_power-v1-0-18d36b548c48@oss.qualcomm.com?part=2