Re: [PATCH v3 03/12] dt-bindings: iio: dac: ad5686: add reset/ldac/gain support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The conditional block restricts `gain-gpios` for single-channel variants but omits several multi-channel variants (e.g., `adi,ad5672r`, `adi,ad5676`, `adi,ad5674r`, `adi,ad5679r`) that lack a physical GAIN pin and internal multiplier. It also fails to restrict the `adi,range-double` property for these multi-channel variants.
--

commit aa16b66ecffaca7347b3cea2e8c47bd2390db0b1
Author: Rodrigo Alencar <rodrigo.alencar@analog.com>

dt-bindings: iio: dac: ad5686: add reset/ldac/gain support

This commit adds GPIO properties for RESET, LDAC, and GAIN pins to the
ad5686 device tree binding. It also adds an adi,range-double property to
indicate when the GAIN pin is hardwired high.

> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml
> --- a/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml

[ ... ]

>  allOf:
>    - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            anyOf:
> +              - const: adi,ad5310r
> +              - const: adi,ad5681r
> +              - const: adi,ad5682r
> +              - const: adi,ad5683
> +              - const: adi,ad5683r
> +    then:
> +      properties:
> +        gain-gpios: false
>  
>  unevaluatedProperties: false

[Severity: Medium]
Does this conditional block also need to restrict gain-gpios and
adi,range-double for multi-channel variants that lack a physical GAIN pin?

Variants like adi,ad5672r, adi,ad5676, adi,ad5674r, and adi,ad5679r also
seem to lack this hardware pin and an internal multiplier. If omitted from
this list, the binding allows these properties to pass validation for
incompatible hardware.

Furthermore, if adi,range-double is provided for these multi-channel
variants, the driver might initialize with double_scale = true and
permanently report an incorrect 2x output voltage scale to userspace.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260616-ad5686-new-features-v3-0-f829fb7e9262@analog.com?part=3