Re: [PATCH v2] dt-bindings: rtc: Convert rtc-cmos binding to YAML

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [Low] The node name in the YAML example uses a unit address that does not match its 'reg' property, which will cause a dtc warning and fail `make dt_binding_check`.
- [Low] A stray file `result.txt` containing intermediate search and build output was accidentally included in the patch.
- [Low] Important explanatory text about firmware initialization was dropped during the conversion to YAML.
--

commit 141cef115f7766092691376134d5e5d70aca938a
Author: Teja Sai Charan Bellamkonda <tejaasaye@gmail.com>

dt-bindings: rtc: Convert rtc-cmos binding to YAML

Convert the rtc-cmos devicetree bindings to dt schema.

> diff --git a/Documentation/devicetree/bindings/rtc/rtc-cmos.yaml b/Documentation/devicetree/bindings/rtc/rtc-cmos.yaml
> new file mode 100644
> index 0000000000000..ba4812778115c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/rtc-cmos.yaml

[ ... ]

> +  ctrl-reg:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description:
> +      Initial value of the control register
> +      (also known as Register B).
> +
> +  freq-reg:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description:
> +      Initial value of the frequency register
> +      (also known as Register A).

[Severity: Low]
The original text binding contained information explaining that Register A
and B are usually initialized by firmware (e.g., BIOS), and if not, can be
performed by the driver. Should this explanatory text be preserved in the
descriptions here to retain the original context?

[ ... ]

> +examples:
> +  - |
> +    bus {
> +        #address-cells = <2>;
> +        #size-cells = <1>;
> +
> +        rtc@70 {
> +            compatible = "motorola,mc146818";
> +            reg = <1 0x70 2>;

[Severity: Low]
Since the bus has #address-cells = <2> and the reg property starts with 1,
should the node name be formatted as rtc@1,70 instead of rtc@70? A mismatched
unit address will result in dtc warnings and fail make dt_binding_check.

[ ... ]

> diff --git a/result.txt b/result.txt
> new file mode 100644
> index 0000000000000..5e90660b93ec2
> --- /dev/null
> +++ b/result.txt
> @@ -0,0 +1,17 @@
> +arch/x86/kernel/x86_init.c:42:	{ .compatible = "motorola,mc146818" },
> +arch/x86/platform/ce4100/falconfalls.dts:420:					compatible = "intel,ce4100-rtc", "motorola,mc146818";

[Severity: Low]
Was this result.txt file intentionally included? It appears to be a local
search and build log that accidentally made it into the patch.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260616085659.12809-1-tejaasaye@gmail.com?part=1