From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46FD12E7376; Tue, 16 Jun 2026 13:50:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781617822; cv=none; b=dE5wf5hV+hHTh1zAvZ1MqvmkKf/oHmoOaSkBeVP7EIymibP/toLi0AWlYrkKKLc+FcOPvY3tykZVGqI+Kycqh9KkzA90l3w52ZguZ+6htvdwoPBAMavNQf3FkV5chgj/Q4JP+3KgQwz5MGf688CZgyq0dbodBO6NeBcReDwfTrI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781617822; c=relaxed/simple; bh=KyFXq4rAhOxuQot223j6lYudnMDTj2bMJ3QGczUCfaY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=p96CJeztDOvM8IyfQi7FFdKWop8nXwGLazxqeBjwk8FUhp2pg3XsOCdY3igukIIUc7czjWsTzLyHSVn4QlWisTYqBytobzIQofkKOIkq5pVke0LRoTPSyTDe+2dwd/sxiTcGDqKb5UkPo53O/trc0fGvvfabvUrju74FfJ0fLw4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bctDtHcg; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bctDtHcg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E72581F00A3A; Tue, 16 Jun 2026 13:50:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781617821; bh=8Xk0PdLiYymMCUqB6kWMCwekoJyvD8MM/ojXTg/ijko=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=bctDtHcgCuI3AA4NjgzsGt6xKEfxgIvEO1rFEtIVw0SvA0e8sDjRtlT+QFfGqT4xx MEy8vspJNIdbfF1LCuWkQ1xpygdYURwY68TtcT8h6LoFzLVSiKiqyiYnHsB2mO927Z cxXJIYfaehrwxMRwpbUcC+9UuFaUYuCxKd56iJdtsTzLNYoRVeTU+NWVVF9HsPQJLb fB28TqMMOXyBuextma02GV38UzL0h4FAQoSKsn05nDPunPEWBrguWxTVRj1SzQ8aCR O4G061n0UmZScpEF2jgoDNm+/yC0Uk/WqgFLsrAI5M/TGIvdmAhLDa6tZ1EVmQZ4jH uCBlivyCU/Esg== Date: Tue, 16 Jun 2026 08:50:17 -0500 From: Rob Herring To: Luca Leonardo Scorcia Cc: linux-mediatek@lists.infradead.org, Dmitry Torokhov , Krzysztof Kozlowski , Conor Dooley , Sen Chu , Sean Wang , Macpaul Lin , Lee Jones , Matthias Brugger , AngeloGioacchino Del Regno , Liam Girdwood , Mark Brown , Linus Walleij , Val Packett , Julien Massot , Louis-Alexis Eyraud , Fabien Parent , Akari Tsuyukusa , Chen Zhong , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH v7 3/9] regulator: dt-bindings: Add MediaTek MT6392 PMIC Message-ID: <20260616135017.GA2350711-robh@kernel.org> References: <20260615071836.362883-1-l.scorcia@gmail.com> <20260615071836.362883-4-l.scorcia@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260615071836.362883-4-l.scorcia@gmail.com> On Mon, Jun 15, 2026 at 09:16:09AM +0200, Luca Leonardo Scorcia wrote: > Add bindings for the regulators found in the MediaTek MT6392 PMIC, > usually found in board designs using the MediaTek MT8516/MT8167 SoCs. > > Signed-off-by: Luca Leonardo Scorcia > --- > .../regulator/mediatek,mt6392-regulator.yaml | 234 ++++++++++++++++++ > .../regulator/mediatek,mt6392-regulator.h | 24 ++ > 2 files changed, 258 insertions(+) > create mode 100644 Documentation/devicetree/bindings/regulator/mediatek,mt6392-regulator.yaml > create mode 100644 include/dt-bindings/regulator/mediatek,mt6392-regulator.h > > diff --git a/Documentation/devicetree/bindings/regulator/mediatek,mt6392-regulator.yaml b/Documentation/devicetree/bindings/regulator/mediatek,mt6392-regulator.yaml > new file mode 100644 > index 000000000000..197041df4ba1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/regulator/mediatek,mt6392-regulator.yaml > @@ -0,0 +1,234 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/regulator/mediatek,mt6392-regulator.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek MT6392 regulator > + > +maintainers: > + - Luca Leonardo Scorcia > + > +description: > + MT6392 is a power management system chip containing three buck converters and > + 23 LDOs. All voltage regulators provided by the PMIC are described as > + sub-nodes of this node. > + > +properties: > + compatible: > + items: > + - const: mediatek,mt6392-regulator > + > + vproc-supply: > + description: Supply for buck regulator vproc > + vcore-supply: > + description: Supply for buck regulator vcore > + vsys-supply: > + description: Supply for buck regulator vsys > + avddldo-supply: > + description: | Don't need '|' if no formatting to preserve. Elsewhere too. > + Supply for AVDD LDOs (vm, vio18, vcn18, vcamd, vcamio). According to the data sheet > + this is an internal supply derived from vsys. > + ldo1-supply: > + description: Supply for LDOs group 1 (vaud28, vxo22, vaud22, vadc18, vcama, vrtc) > + ldo2-supply: > + description: Supply for LDOs group 2 (vcn35, vio28, vmc, vmch, vefuse, vdig18) > + ldo3-supply: > + description: Supply for LDOs group 3 (vusb, vemc3v3, vcamaf, vgp1, vgp2, vm25) > + > +patternProperties: > + "^v(core|proc|sys)$": > + description: Buck regulators > + type: object > + $ref: regulator.yaml# > + properties: > + regulator-allowed-modes: > + description: | > + BUCK regulators can set regulator-initial-mode and regulator-allowed-modes to > + values specified in dt-bindings/regulator/mediatek,mt6392-regulator.h > + items: > + enum: [0, 1] minItems: 1 maxItems: 2 ? Because if there are only 2 modes, can't have more entries than that, right? Though wouldn't 2 entries be the same as no property present because I would assume the default is all modes. I shouldn't have to assume though. > + unevaluatedProperties: false Place this after $ref. Easier to read than after indented blocks. > + > + "^v(adc18|camio|cn18|io18|xo22|m25|aud28|io28|rtc|usb)$": > + description: LDOs with fixed output and mode setting > + type: object > + $ref: regulator.yaml# > + properties: > + regulator-allowed-modes: > + description: | > + LDO regulators can set regulator-initial-mode and regulator-allowed-modes to > + values specified in dt-bindings/regulator/mediatek,mt6392-regulator.h > + items: > + enum: [0, 1] > + unevaluatedProperties: false > + > + "^v(cama|dig18)$": > + description: LDOs with fixed output without mode setting > + type: object > + $ref: regulator.yaml# > + unevaluatedProperties: false > + > + "^v(aud22|camaf|camd|cn35|efuse|emc3v3|gp1|gp2|m|mc|mch)$": > + description: LDOs with adjustable output > + type: object > + $ref: regulator.yaml# > + properties: > + regulator-allowed-modes: false > + unevaluatedProperties: false > + > +required: > + - compatible > + > +additionalProperties: false > + > +examples: > + - | > + #include > + > + regulators { > + compatible = "mediatek,mt6392-regulator"; Drop the example. Put 1 complete example in the MFD schema rather than incomplete examples. Rob