Re: [PATCH v9 1/3] dt-bindings: timer: mips,p8700-gcru

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Usage of deprecated vendor prefix 'mips,' for a new compatible string.
--

commit 26c5e0f809bd1633d85e1be068047d23439d144d
Author: Aleksa Paunovic <aleksa.paunovic@htecgroup.com>

dt-bindings: timer: mips,p8700-gcru

Add dt-bindings for the GCR.U memory mapped timer device for RISC-V platforms.
The GCR.U memory region contains shadow copies of the RISC-V mtime register
and the hrtime Global Configuration Register.

> diff --git a/Documentation/devicetree/bindings/timer/mips,p8700-gcru.yaml b/Documentation/devicetree/bindings/timer/mips,p8700-gcru.yaml
> new file mode 100644
> index 0000000000000..e6f25e769f461
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/timer/mips,p8700-gcru.yaml
> @@ -0,0 +1,38 @@

[ ... ]

> +properties:
> +  compatible:
> +    const: mips,p8700-gcru

[Severity: Low]
Is the mips, vendor prefix deprecated for new device tree bindings?

Looking at Documentation/devicetree/bindings/vendor-prefixes.yaml, the mips
prefix is explicitly marked as deprecated, with recommendations to use mti
or img instead. If this prefix is intended to be reclaimed for new hardware,
does it first need to be formally undeprecated in the vendor prefixes list?

[ ... ]

> +examples:
> +  - |
> +    timer@1617f050 {
> +        compatible = "mips,p8700-gcru";

[Severity: Low]
This example similarly reinforces the use of the potentially deprecated mips,
vendor prefix. Should this be updated to use mti,img, or another approved
vendor prefix to align with subsystem conventions?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260616-riscv-time-mmio-v9-0-03af7bc8f2d8@htecgroup.com?part=1