From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 023C33914E4 for ; Tue, 16 Jun 2026 20:42:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781642541; cv=none; b=R16okAGjU9F4MBzCH+/C6IWJF1RoqcGWMzrDblkEfiRwAsqyMPRjyuMzKJu+0c00Z67qGF3KSFD70hv3bxRojPd9dTkrPJ40GHqcVUEd5HpfU6QYBxrOgryDTVq4W5Kg+nE0onTRFSuxEqHsmjgzrflyLoakXlfZV96ENbyZkQc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781642541; c=relaxed/simple; bh=Or9bAfCNwkEIuN1ANhhLmy2yIYWdepEhgD2OGOZ6fLs=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=EIcxwWF9PLiAYsLFFD4T4ZoWS38N+lhT3KsGV8pMFGrUzE5OCHcni1kpRKaxNj58Zgp7Nzy9TkaarcoDAbGEl91QIm/dKvod1ESZAWOcNJSe967qFTGiBNphlKBlgD5YtP4mdtRCbjV/7seNgz7eVoM/HXNyMcEBOr/0MBRWd9E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BUI0AdPa; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BUI0AdPa" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53B6D1F000E9; Tue, 16 Jun 2026 20:42:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781642540; bh=5iZpV9hLBV39baHVa+FzcvMC+lt+OAI4sywaWCGFyLc=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=BUI0AdPaMAwaPeRp5a5zjbSGJ5GSergoRUe6VXocVYAJvVEaVguYodEP8obcl5O7c 6SWIEnVqIPWxVafWZVkllhIo2LQkcp/bfbbju6iWOqRNiy7wRCPUGBnVv7N8Lzhz/F Azp3ZmXdK++TKDNeFmETF39yOTTOiRJ76l7sN0lEpDOn4fQrZbFz3F9u/QbgJ75ENy q85s0OfBSIfOgzKA85ph8RDn6EzN4M1WOfhYNW04l6CLqb/GXGRAgqq3CdEHPt/CyB XHwCOztTJ1AX/xJxk6g9N5hg5zo65fXCPi01uInanX1aI1yNqKBaWiHaCuDxmfV5JI Kz/nrlpYV6H7A== From: sashiko-bot@kernel.org Subject: Re: [PATCH RFC v4 12/12] ARM: dts: zte: Add a syscon-reboot for zx297520v3 boards Reply-To: sashiko-reviews@lists.linux.dev To: =?utf-8?b?U3RlZmFuIETDtnNpbmdlcg==?= Cc: devicetree@vger.kernel.org, conor+dt@kernel.org, robh@kernel.org In-Reply-To: <20260616-zx29clk-v4-12-ca994bd22e9d@gmail.com> References: <20260616-zx29clk-v4-12-ca994bd22e9d@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 16 Jun 2026 20:42:19 +0000 Message-Id: <20260616204220.53B6D1F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] The `syscon-reboot` node is incorrectly defined at the root level u= sing the explicitly deprecated `regmap` property. -- commit afa99cf55be8056135e61b54fc719550822bda85 Author: Stefan D=C3=B6singer ARM: dts: zte: Add a syscon-reboot for zx297520v3 boards This commit adds a syscon-reboot node to the zx297520v3 device tree. It all= ows resetting the board by writing a value to a register exposed by the topclk syscon. > diff --git a/arch/arm/boot/dts/zte/zx297520v3.dtsi b/arch/arm/boot/dts/zt= e/zx297520v3.dtsi > index a2b6909e7434d..013ece51c2a09 100644 > --- a/arch/arm/boot/dts/zte/zx297520v3.dtsi > +++ b/arch/arm/boot/dts/zte/zx297520v3.dtsi > @@ -33,6 +33,13 @@ osc32k: osc32k { > #clock-cells =3D <0>; > }; > =20 > + syscon-reboot { > + compatible =3D "syscon-reboot"; > + regmap =3D <&topclk>; [Severity: Low] Does this use a deprecated property? According to the syscon-reboot device tree bindings, the regmap property is explicitly deprecated. The documented modern requirement is to define the syscon-reboot node as a child of the system controller node. Introducing new nodes using deprecated bindings can trigger make dtbs_check warnings. To resolve this, the syscon-reboot node could be moved to be a child of top= clk, and topclk's compatible string could be updated to include "simple-mfd" to ensure the driver core automatically probes the child node. > + offset =3D <0x0>; > + mask =3D <0x1>; > + }; --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260616-zx29clk-v4= -0-ca994bd22e9d@gmail.com?part=3D12