Re: [PATCH v2 1/2] dt-bindings: gpu: img,powervr-rogue: Document GE8300 GPU in Renesas R-Car D3

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 3135 bytes --]

On Tue, Jun 16, 2026 at 08:28:02PM +0200, Niklas Söderlund wrote:
> On 2026-06-16 19:58:34 +0200, Niklas Söderlund wrote:
> > Document Imagination Technologies PowerVR Rogue GE8300 BNVC 22.67.54.30
> > present in Renesas R-Car R8A77995 D3 SoCs.
> > 
> > Compared to other R-Car Gen3 SoCs the D3 only have one power domain and
> > it is always on. Extend the list of special cases for this to also cover
> > R8A77995 and update the description of it.
> > 
> > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > * Changes since v1
> > - Sort img,img-ge8300 after img,img-ge7800.
> > - Fold special case for power domain into an existing one and update the
> >   description.
> > ---
> >  .../devicetree/bindings/gpu/img,powervr-rogue.yaml | 14 ++++++++++----
> >  1 file changed, 10 insertions(+), 4 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
> > index a1f54dbae3f3..b93f49f1fa0a 100644
> > --- a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
> > +++ b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
> > @@ -25,6 +25,11 @@ properties:
> >                - renesas,r8a779a0-gpu
> >            - const: img,img-ge7800
> >            - const: img,img-rogue
> > +      - items:
> > +          - enum:
> > +              - renesas,r8a77995-gpu
> > +          - const: img,img-ge8300
> > +          - const: img,img-rogue
> >        - items:
> >            - enum:
> >                - ti,am62-gpu
> > @@ -114,6 +119,7 @@ allOf:
> >            contains:
> >              enum:
> >                - img,img-ge7800
> > +              - img,img-ge8300
> >                - img,img-gx6250
> >                - thead,th1520-gpu
> >      then:
> > @@ -159,14 +165,14 @@ allOf:
> >    - if:
> >        properties:
> >          compatible:
> > -          contains:
> 
> The 'contains' node should have been kept, my bad. I wonder why 'make 
> dt_binding_check' or `make dtbs_check' did not catch it. Sorry for the 
> noise.

Because it's valid syntax, the contains syntax means that it'll match
against things that use the listed compatibles as fallbacks. What you
have done works for exact matches only.

I think recently Rob said the contains syntax is preferred, with some
rationale that escapes me.

> 
> > -            const: thead,th1520-gpu
> > +          enum:
> > +            - renesas,r8a77995-gpu
> > +            - thead,th1520-gpu
> >      then:
> >        properties:
> >          power-domains:
> >            items:
> > -            - description: The single, unified power domain for the GPU on the
> > -                TH1520 SoC, integrating all internal IP power domains.
> > +            - description: The single, unified power domain for the GPU.
> >          power-domain-names: false
> >        required:
> >          - power-domains
> > -- 
> > 2.54.0
> > 
> 
> -- 
> Kind Regards,
> Niklas Söderlund

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]