From: sashiko-bot@kernel.org
To: "Mike Hsieh" <mike.quanta.115@gmail.com>
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org, robh@kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: aspeed: sanmiguel: add current-range property for PDB HSC
Date: Thu, 18 Jun 2026 07:48:26 +0000 [thread overview]
Message-ID: <20260618074826.CA6671F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260618-sanmiguel-dts-config-hsc-lm5066i-v1-2-cccf959c9b78@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `ti,current-range` property is undocumented in the devicetree bindings, completely unhandled by the kernel, and will cause `dtbs_check` validation failures.
--
commit 896bc796365efa4f0c156564af30ed91fd361842
Author: Mike Hsieh <mike.quanta.115@gmail.com>
ARM: dts: aspeed: sanmiguel: add current-range property for PDB HSC
This commit defines the hardware current limit operating mode for four
TI LM5066i hot-swap controllers on the PDB board. It does this by adding
the ti,current-range property to each sensor's device tree node.
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-sanmiguel.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-sanmiguel.dts
> index 3faac0925a797..e518e3fc1c97e 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-sanmiguel.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-sanmiguel.dts
> @@ -451,6 +451,7 @@ pdb_ti_hsc1: power-monitor@11 {
> compatible = "ti,lm5066i";
> reg = <0x11>;
> shunt-resistor-micro-ohms = <1000>;
> + ti,current-range = "low";
[Severity: Medium]
Is this property documented in the devicetree bindings?
Looking at the schema for ti,lm5066i in
Documentation/devicetree/bindings/hwmon/pmbus/ti,lm25066.yaml, it enforces
unevaluatedProperties: false. Will adding this property cause make dtbs_check
to fail?
The commit message mentions this property configures the hardware current
limit, but does the kernel actually parse ti,current-range?
It appears the driver in drivers/hwmon/pmbus/lm25066.c natively discovers the
limit by dynamically reading the device setup register via I2C at probe time,
which would mean this property is unhandled by the kernel and effectively dead
code.
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260618-sanmiguel-dts-config-hsc-lm5066i-v1-0-cccf959c9b78@gmail.com?part=2
prev parent reply other threads:[~2026-06-18 7:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-18 7:41 [PATCH 0/2] ARM: dts: aspeed: sanmiguel: configure LM5066i HSCs for PDB Mike Hsieh
2026-06-18 7:41 ` [PATCH 1/2] ARM: dts: aspeed: sanmiguel: fix PDB HSC shunt resistor Mike Hsieh
2026-06-18 7:41 ` [PATCH 2/2] ARM: dts: aspeed: sanmiguel: add current-range property for PDB HSC Mike Hsieh
2026-06-18 7:48 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260618074826.CA6671F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=mike.quanta.115@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox