Re: [PATCH 1/2] dt-bindings: pwm: add Axiado AX3000 PWM

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `#pwm-cells` property is missing from the `required` list in the device tree binding schema.
--

commit ecac4ef8f05dd912d17935a0faabe9c81c3d921c
Author: Petar Stepanovic <pstepanovic@axiado.com>

dt-bindings: pwm: add Axiado AX3000 PWM

This commit introduces the device tree binding schema and maintainer entry
for the Axiado AX3000 and AX3005 PWM controllers.

> diff --git a/Documentation/devicetree/bindings/pwm/axiado,ax3000-pwm.yaml b/Documentation/devicetree/bindings/pwm/axiado,ax3000-pwm.yaml
> new file mode 100644
> index 0000000000000..8e5fee8c499d5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/axiado,ax3000-pwm.yaml

[ ... ]

> +  "#pwm-cells":
> +    const: 2
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks

[Severity: Medium]
Should "#pwm-cells" be included in this required list?

According to the device tree bindings subsystem guidelines, when a hardware
component provides PWM capabilities, the corresponding cell-count property
("#pwm-cells") must be explicitly included in the required list.

Omitting it allows incomplete device tree nodes missing the "#pwm-cells"
property to silently pass schema validation. This defeats the purpose of
the schema validation and can lead to runtime failures if dependent drivers
attempt to use an improperly configured node.

> +
> +additionalProperties: false

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260618-axiado-ax3000-pwm-v1-0-c9797a909414@axiado.com?part=1