Re: [PATCH v3] spi: dt-bindings: octeon: Convert to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incorrect maintainer attribution in the converted devicetree binding.
--

commit 4c13bfaa3139030f2d12bf30e37ab22833e428f3
Author: Ninad Naik <ninadnaik07@gmail.com>

spi: dt-bindings: octeon: Convert to DT schema

This commit converts the devicetree bindings for the Cavium OCTEON 3010 SPI
controller from plain text format to YAML schema.

> diff --git a/Documentation/devicetree/bindings/spi/cavium,octeon-3010-spi.yaml b/Documentation/devicetree/bindings/spi/cavium,octeon-3010-spi.yaml
> new file mode 100644
> index 0000000000000..f0b708e1ccbbf
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/spi/cavium,octeon-3010-spi.yaml
> @@ -0,0 +1,61 @@

[ ... ]

> +title: Cavium, Inc. OCTEON SoC SPI master controller
> +
> +description:
> +  The Cavium OCTEON SPI controller is an SPI master controller found in
> +  OCTEON SoCs.
> +
> +maintainers:
> +  - Rob Herring <robh@kernel.org>

[Severity: Low]
Is Rob Herring the intended maintainer for this specific hardware binding?

Typically during text-to-yaml conversions, it is preferred to list the actual
hardware maintainer, platform maintainer, or the patch author here rather
than the core devicetree maintainer. This ensures get_maintainer.pl routes
future hardware-specific queries and patches correctly without sending
unnecessary mail to the core devicetree maintainers.

> +
> +allOf:
> +  - $ref: spi-controller.yaml#

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260618180149.475658-1-ninadnaik07@gmail.com?part=1