Re: [PATCH 2/2] arm: dts: xilinx: Add support for MYIR MYS-7Z020-V2 board

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Missing function multiplexing for SD card detect (CD) pin, causing SD card detection to fail.
--

commit d502783eb06999075d769495567d3ef9a776e3f7
Author: Liu Yu <f78fk@live.com>

arm: dts: xilinx: Add support for MYIR MYS-7Z020-V2 board

Add device tree support for the MYIR MYS-7Z020-V2 board based on
the Xilinx Zynq-7000 XC7Z020 SoC.

Link: https://www.myirtech.com/list.asp?id=708

> diff --git a/arch/arm/boot/dts/xilinx/zynq-mys-7z020-v2.dts b/arch/arm/boot/dts/xilinx/zynq-mys-7z020-v2.dts
> new file mode 100644
> index 0000000000000..39bd864ca358d
> --- /dev/null
> +++ b/arch/arm/boot/dts/xilinx/zynq-mys-7z020-v2.dts

[ ... ]

> +&pinctrl0 {

[ ... ]

> +	pinctrl_sdhci0_default: sdhci0-default {
> +		mux {
> +			groups = "sdio0_2_grp";
> +			function = "sdio0";
> +		};
> +		conf {
> +			groups = "sdio0_2_grp";
> +			slew-rate = <0>;
> +			io-standard = <1>;
> +			bias-disable;
> +		};
> +		conf-cd {
> +			pins = "MIO46";
> +			bias-pull-up;
> +			slew-rate = <0>;
> +			io-standard = <1>;
> +		};

[Severity: High]
Does this pin configuration properly route the SD card detect signal to the
SDHCI controller?

The conf-cd block sets the electrical properties for MIO46, but it appears
to lack the required multiplexing configuration. In the Zynq pinctrl driver,
routing the SD card detect signal requires explicitly requesting the
sdio0_cd function.

Without defining a mux node (such as adding a mux-cd block with
groups = "gpio0_46_grp" and function = "sdio0_cd"), the Linux pinctrl
driver will not route the internal SDHCI controller's CD line to MIO46.
Unless the bootloader pre-configures this mux and the configuration
survives suspend and resume cycles, the SD controller will likely fail
to detect card insertion or removal.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260619102214.223121-1-f78fk@live.com?part=2