Re: [PATCH v5 1/1] arm64: dts: add tqma9596la-mba95xxca

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [Medium] Duplicate and incorrect GPIO hog line name `M2_KEYB_WDISABLE1#` in `expander3`.
- [Low] Incorrect regulator referenced for `expander2` `vcc-supply`.
- [Low] Typos in pinctrl node names for retimer and typec groups.
--

commit fb001fddc405cd85f401d1d2351baf577241c535
Author: Markus Niebel <Markus.Niebel@ew.tq-group.com>

arm64: dts: add tqma9596la-mba95xxca

This commit adds device tree support for the TQMa95xxLA modules on the
MBa95xxCA carrier board. It configures PCIe, clocks, reset GPIOs, and adds
GPIO hogs for the M.2 slots.

> diff --git a/arch/arm64/boot/dts/freescale/imx95-tqma9596la-mba95xxca.dts b/arch/arm64/boot/dts/freescale/imx95-tqma9596la-mba95xxca.dts
> new file mode 100644
> index 0000000000000..4b49f6cf731da
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx95-tqma9596la-mba95xxca.dts

[ ... ]

> +	/* D40 OUT 3V3 */
> +	expander2: gpio@75 {
> +		compatible = "ti,tca9539";
> +		reg = <0x75>;
> +		vcc-supply = <&reg_3v3>;

[Severity: Low]
Does this point to the SoM regulator instead of the intended mainboard
regulator? Since expander2 is a mainboard component, shouldn't this reference
<&reg_v3v3_mb>?

> +		gpio-controller;
> +		#gpio-cells = <2>;

[ ... ]

> +	/* D41 OUT 1V8 */
> +	expander3: gpio@76 {
> +		compatible = "ti,tca9539";
> +		reg = <0x76>;

[ ... ]

> +		m2-keyb-wdisable2-hog {
> +			gpio-hog;
> +			gpios = <5 GPIO_ACTIVE_LOW>;
> +			output-low;
> +			line-name = "M2_KEYB_WDISABLE1#";

[Severity: Medium]
Does this duplicate the line-name used in expander2 for
m2-keyb-wdisable1-hog? This could cause a naming collision in gpiolib. Should
this be named "M2_KEYB_WDISABLE2#" instead?

> +		};

[ ... ]

> +	pinctrl_retimer: retirmergrp {

[Severity: Low]
This isn't a bug, but there's a typo in the node name (retirmergrp instead
of retimergrp).

> +		fsl,pins = <IMX95_PAD_GPIO_IO29__GPIO2_IO_BIT29			0x1100>;
> +	};

[ ... ]

> +	pinctrl_typec: typcegrp {

[Severity: Low]
This isn't a bug, but there's a typo in the node name (typcegrp instead
of typecgrp).

> +		fsl,pins = <IMX95_PAD_GPIO_IO28__GPIO2_IO_BIT28			0x1100>;
> +	};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260619112434.1121610-1-alexander.stein@ew.tq-group.com?part=1