From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02CD8396579 for ; Fri, 19 Jun 2026 15:28:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781882937; cv=none; b=nJPoTVimz69ZbDiDuclwVuqjjyRxfmiEkplO91p0p0HuEBOHkYm15/o0iPWmtNqYvfdxYb9h8vKeBzat0/CclbB3AUXu8xA3oArVn8pT282ZSDqvDPiLVBdYs+6Yg8TZVl3NChsc8zH3GO6a7kHbwHo+kGkjlJnBJKBj+4TJV58= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781882937; c=relaxed/simple; bh=GKw68cnmyDXYtkcglFObx6T2nfKn6oeKuFMIYWcNHJ0=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=IEFD7uBEhrGSsgB1LVsC6rZqgQGSC7bOguyaDs3SMq6NSidoJ7UJbmHTRxS5gPSWiXoSdVnvsGaW/liRCKyUiOK7WmqzwHPBJ52eNikncMiGDvogEvQQcFA0/xK2qWbiBcr/SE9h6+jekv4Npt5+wSkNrZo5ILeD96i35tBliiI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=n91EoPl1; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="n91EoPl1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5B721F000E9; Fri, 19 Jun 2026 15:28:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781882935; bh=FmgIDUtYYmvZir76ggvDWCMY7v4oAhr9ErlwbyAUwaE=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=n91EoPl1aWR23ieTI/uGO3UP1U9JaKed2nrVjmb6QiEMiACKBzK07u5k8j6/j+jwz b8m/EXBYYtdXuKU9heTUfCsoFpr3hbsN4apHIDTCfCGX6caISGkaBnkyVz0MVyHj+N thMCeWGDpcTw8UiQQOzyl3Q5wmyUcYQpzmLs1hsbiNVTwDPSI8LwvhNPwuNPHY266s WVT1gwXGjI2+f4Gcgby/16vMyanRHvgrlm9Use4blADoCP1/oTXztAjkWS8xUbwPeV F5359ERGugjsG6OqFbgocHRyIMIp+Rh3vrXHc4mOocCUGx0pvO6nxwQNfQLnhPtff+ vlclucfF1Pvvg== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 1/2] spi: dt-bindings: snps,dw-apb-ssi: Add starfive,jhb100-spi Reply-To: sashiko-reviews@lists.linux.dev To: "Changhuang Liang" Cc: conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org In-Reply-To: <20260619143443.22267-2-changhuang.liang@starfivetech.com> References: <20260619143443.22267-1-changhuang.liang@starfivetech.com> <20260619143443.22267-2-changhuang.liang@starfivetech.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 19 Jun 2026 15:28:55 +0000 Message-Id: <20260619152855.A5B721F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] The patch introduces 'snps,dwc-ssi-2.00a' as a fallback compatib= le string but does not document it as a standalone generic compatible. -- commit a0b5bdaa0ec7a10bb2b844ee5ff0f01be111deee Author: Changhuang Liang spi: dt-bindings: snps,dw-apb-ssi: Add starfive,jhb100-spi Add a new compatible string "starfive,jhb100-spi" for the StarFive JHB100 SPI, it based on the Synopsys DesignWare SSI version 2.00a, uses snps,dwc-ssi-2.00a as the primary fallback and snps,dwc-ssi-1.01a as the secondary fallback. > diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b= /Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > index 8ebebcebca160..4458316326fc4 100644 > --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > @@ -54,6 +54,12 @@ properties: > - sophgo,sg2042-spi > - thead,th1520-spi > - const: snps,dw-apb-ssi > + - description: Vendor controllers which use snps,dwc-ssi-2.00a as = fallback > + items: > + - enum: > + - starfive,jhb100-spi > + - const: snps,dwc-ssi-2.00a > + - const: snps,dwc-ssi-1.01a [Severity: Medium] Since snps,dwc-ssi-2.00a is introduced as a fallback here, should it also be added as a valid standalone string under the "Generic DW SPI Controller" en= um list earlier in properties:compatible:oneOf? If it is omitted from the generic enum list, any future device tree nodes that use the generic Synopsys 2.00a IP core without a vendor prefix might fail schema validation. For context, the existing generic list only contains snps,dwc-ssi-1.01a and snps,dw-apb-ssi: compatible: oneOf: - description: Generic DW SPI Controller enum: - snps,dw-apb-ssi - snps,dwc-ssi-1.01a --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260619143443.2226= 7-1-changhuang.liang@starfivetech.com?part=3D1