From: sashiko-bot@kernel.org
To: "Vishwas Udupa" <vishwas.udupa@oss.qualcomm.com>
Cc: robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2] arm64: dts: qcom: install DT overlays via dtbs_install
Date: Fri, 19 Jun 2026 18:15:16 +0000 [thread overview]
Message-ID: <20260619181517.9BD311F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260619180951.325272-1-vishwas.udupa@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message inaccurately claims to add 'all DT overlays defined in this Makefile' while intentionally omitting EL2 overlays.
--
commit fbeb39cf8d645f798555d038d5b4a1e5e3393c7a
Author: Vishwas Udupa <vishwas.udupa@oss.qualcomm.com>
arm64: dts: qcom: install DT overlays via dtbs_install
This commit adds explicit install targets for Device Tree overlays (.dtbo)
in the qcom Makefile so they can be packaged alongside normal DTBs via the
standard dtbs_install flow.
> Even when final DTBs are produced at build time, some distributions rely on
> standalone DTBOs for runtime selection and application by bootloaders or
> firmware. Without explicit install targets, DTBOs are not picked up by the
> standard dtbs_install flow and therefore cannot be packaged alongside DTBs.
>
> Add explicit dtb-$(CONFIG_ARCH_QCOM) entries for all DT overlays defined in
> this Makefile so they are installed via dtbs_install, matching existing
> DTB install behaviour.
[Severity: Medium]
Is this description accurate? The commit message states that all DT overlays
defined in the Makefile are added, but the patch appears to systematically
omit EL2 overlays.
[ ... ]
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
[ ... ]
> lemans-evk-el2-dtbs := lemans-evk.dtb lemans-el2.dtbo
>
> dtb-$(CONFIG_ARCH_QCOM) += lemans-evk-el2.dtb
> lemans-evk-ifp-mezzanine-dtbs := lemans-evk.dtb lemans-evk-ifp-mezzanine.dtbo
> dtb-$(CONFIG_ARCH_QCOM) += lemans-evk-ifp-mezzanine.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += lemans-evk-ifp-mezzanine.dtbo
For example, lemans-evk-ifp-mezzanine.dtbo is explicitly added here, but
the adjacent lemans-el2.dtbo is conspicuously skipped. Similar omissions
occur for monaco-el2.dtbo and x1-el2.dtbo further down in the patch.
Could the commit message be updated to clarify that EL2 overlays are
intentionally excluded from standalone installation?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260619180951.325272-1-vishwas.udupa@oss.qualcomm.com?part=1
prev parent reply other threads:[~2026-06-19 18:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 12:37 [PATCH] arm64: dts: qcom: install DT overlays via dtbs_install Vishwas Udupa
2026-06-15 5:00 ` Krzysztof Kozlowski
2026-06-15 16:27 ` Vishwas Udupa
2026-06-16 3:49 ` Krzysztof Kozlowski
2026-06-19 18:09 ` [PATCH v2] " Vishwas Udupa
2026-06-19 18:15 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260619181517.9BD311F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vishwas.udupa@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox