From: sashiko-bot@kernel.org
To: "Otto Pflüger" <otto.pflueger@abscue.de>
Cc: robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v6 1/3] regulator: dt-bindings: Add Unisoc SC2730 PMIC
Date: Sat, 20 Jun 2026 09:05:06 +0000 [thread overview]
Message-ID: <20260620090507.0E3171F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260620-sc2730-regulators-v6-1-bbd2db395231@abscue.de>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The YAML binding schema omits the `properties` block defining the `compatible` property, causing schema validation to fail if device trees include it and allowing incomplete nodes to incorrectly pass validation.
--
commit 8c5bcc12a2e0793aa168b5a819709950e4b101f4
Author: Otto Pflüger <otto.pflueger@abscue.de>
regulator: dt-bindings: Add Unisoc SC2730 PMIC
This commit adds the device tree binding schema for the regulators found
in the Spreadtrum/Unisoc SC2730 PMIC.
> diff --git a/Documentation/devicetree/bindings/regulator/sprd,sc2730-regulator.yaml b/Documentation/devicetree/bindings/regulator/sprd,sc2730-regulator.yaml
> new file mode 100644
> index 0000000000000..ab945c46b08e0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/sprd,sc2730-regulator.yaml
[ ... ]
> "^ldo-vddrf(1v25|18)$":
> type: object
> $ref: regulator.yaml#
> unevaluatedProperties: false
>
> additionalProperties: false
[Severity: Medium]
Should there be a properties block defining the compatible string here?
Because this schema specifies additionalProperties: false but omits a
properties block and a required list for the compatible string, it acts
as a catch-all that can successfully validate an empty regulators node.
Furthermore, if a device tree author specifies a compatible string (such
as compatible = "sprd,sc2730-regulator"), validation will falsely fail
due to the additionalProperties constraint. Could a properties block and
a required list be added to explicitly allow and require the compatible
property?
> ...
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260620-sc2730-regulators-v6-0-bbd2db395231@abscue.de?part=1
next prev parent reply other threads:[~2026-06-20 9:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-20 8:53 [PATCH v6 0/3] regulator: Add support for Unisoc SC2730 PMIC regulators Otto Pflüger
2026-06-20 8:54 ` [PATCH v6 1/3] regulator: dt-bindings: Add Unisoc SC2730 PMIC Otto Pflüger
2026-06-20 9:05 ` sashiko-bot [this message]
2026-06-20 8:54 ` [PATCH v6 2/3] mfd: sprd-sc27xx: Add SC2730 regulator cell Otto Pflüger
2026-06-20 9:04 ` sashiko-bot
2026-06-20 8:54 ` [PATCH v6 3/3] regulator: Add regulator driver for Unisoc SC2730 PMIC Otto Pflüger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260620090507.0E3171F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=otto.pflueger@abscue.de \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox