From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 817E127874F; Sat, 20 Jun 2026 13:27:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781962082; cv=none; b=Xtgnqe9pDouWiE3ataceNC18Hw8HrYlX4pYwjYR/xsCM1AuQzjVPPXYESXA9gI57uU7XP5eoNrfszVr/6ZcrJppsc3t+xIQstJ1mRFeK+opa0YPcb6+NlNuqJ0b1ZOn+JdZHJ6DEHCKs5SzvyMqXj2BFhWloF/bbXeAa3w9u8yg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781962082; c=relaxed/simple; bh=//RtIbbbO+6Y9IggxZGdSw3W2JDAG48tPtlced6Ieys=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ps7UM0/FxG/iBfSbj1GSgk8LG8mREzobUYtYof6Zu4PJ4pRLMpql2q+a03tMZ1sYgCSt6iQxny5qma1MHW8FPJNb6RP+Yyhd/0a7Wes71QQtPf2+4vgp1o6UnVG08MVHRQW/dWUQtRgRUez+LvSDW9+q369JSSQ0wWoF5jUbFNM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=JPePHGKB; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="JPePHGKB" Received: from killaraus.ideasonboard.com (2001-14ba-70f3-e800--a06.rev.dnainternet.fi [IPv6:2001:14ba:70f3:e800::a06]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 56F9A56D; Sat, 20 Jun 2026 15:27:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1781962034; bh=//RtIbbbO+6Y9IggxZGdSw3W2JDAG48tPtlced6Ieys=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JPePHGKBsdJ/lIIINcK6809JnDeJ7nB6JKHdYt0BQK9HNgWiqmu99TF49vtudqT2/ 3jT9AgIHt+2dxYqCA0pk5yV+KlPFElWGV0EjiH/iduccWqJjOwwGpjTIXd/sPN5yeo 2QvTvpYctAzvXVLMQNwTpf/3K61GvrJMmaSyZZQE= Date: Sat, 20 Jun 2026 16:27:49 +0300 From: Laurent Pinchart To: Himanshu Bhavani Cc: sakari.ailus@linux.intel.com, luca.weiss@fairphone.com, Hardevsinh Palaniya , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Hans Verkuil , Hans de Goede , Vladimir Zapolskiy , Elgin Perumbilly , Walter Werner Schneider , Kate Hsuan , Svyatoslav Ryhel , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v2 2/3] media: i2c: add imx576 image sensor driver Message-ID: <20260620132749.GE3552167@killaraus.ideasonboard.com> References: <20260619125439.55311-1-himanshu.bhavani@siliconsignals.io> <20260619125439.55311-3-himanshu.bhavani@siliconsignals.io> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260619125439.55311-3-himanshu.bhavani@siliconsignals.io> On Fri, Jun 19, 2026 at 06:24:32PM +0530, Himanshu Bhavani wrote: > Add a v4l2 subdevice driver for the Sony imx576 sensor. > > The Sony IMX576 image sensor with an active > array size of 5760 x 4312 > > The following features are supported: > - Manual exposure an gain control support > - vblank/hblank control support > - Supported resolution: 2880 x 2156 30fps (SRGGB10) You've been asked in v1 to make this driver dynamically compute registers instead of hardcoding modes. Please do so in v3. Nack on v2. > Signed-off-by: Himanshu Bhavani > --- > MAINTAINERS | 1 + > drivers/media/i2c/Kconfig | 10 + > drivers/media/i2c/Makefile | 1 + > drivers/media/i2c/imx576.c | 1034 ++++++++++++++++++++++++++++++++++++ > 4 files changed, 1046 insertions(+) > create mode 100644 drivers/media/i2c/imx576.c [snip] -- Regards, Laurent Pinchart