Re: [PATCH v8 9/9] arm64: dts: mediatek: Add MediaTek MT6392 PMIC dtsi

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The `pmic` node lacks an upstream `interrupts` or `interrupts-extended` property, causing the MT6397/MT6392 PMIC driver to fail probing.
--

commit fc85085e7df96d6b701cb80ab653d3bbb4392af1
Author: Val Packett <val@packett.cool>

arm64: dts: mediatek: Add MediaTek MT6392 PMIC dtsi

Add the dtsi to be included by all boards using the MT6392 PMIC,
providing support for regulator, keys, pinctrl and RTC. Import the new
file in the shared device tree for the Pumpkin boards.

> diff --git a/arch/arm64/boot/dts/mediatek/mt6392.dtsi b/arch/arm64/boot/dts/mediatek/mt6392.dtsi
> new file mode 100644
> index 0000000000000..19321ae010bba
> --- /dev/null
> +++ b/arch/arm64/boot/dts/mediatek/mt6392.dtsi
> @@ -0,0 +1,148 @@
[ ... ]
> +&pwrap {
> +	pmic: pmic {
> +		compatible = "mediatek,mt6392", "mediatek,mt6323";
> +		interrupt-controller;
> +		#interrupt-cells = <2>;

[ ... ]

> diff --git a/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi b/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi
> index 805fb82138a80..6bc80924cb6cf 100644
> --- a/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi
> @@ -6,6 +6,8 @@
>  
>  #include <dt-bindings/gpio/gpio.h>
>  
> +#include "mt6392.dtsi"
> +

[Severity: High]
Does this inclusion miss the board-specific interrupts definition for the PMIC?

The new mt6392.dtsi defines the pmic node but omits the interrupts property,
as expected for a generic include. However, pumpkin-common.dtsi doesn't appear
to override the &pmic node to provide the board-specific interrupt routing.

Since the MT6397 PMIC core driver aborts probing completely if it cannot find
an interrupt via platform_get_irq(pdev, 0), will this cause the PMIC driver to
fail probing, leaving all PMIC sub-devices unavailable?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260620200032.334192-1-l.scorcia@gmail.com?part=9