From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AF9BB640; Sun, 21 Jun 2026 17:18:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782062296; cv=none; b=qB0oRFt4AZVDGFuFVWdgpdww9Gbm+GzEILt5v9qv5tcTOqziBVwmMpqYj+0MGUjchl6rTnszgLNr4bb+GCBuuZw7LQbBqQnRvn8UxjG/IOUsx2SwfKE7zVcUTyd6cnDo15HkD/k92zcP7Rwq9lAHa7KwMK3NQoaLGMSLl6zvfvw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782062296; c=relaxed/simple; bh=Rf+La8jFVT95KkIR0ldQb6LhrquOwNjriq1Vi5P8ngk=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=d1gAn18xulOsNGXDTByxxjSDItz94c6PuX4bK/cCLMc5Gqbf0z0Jrzj/ntGkh8JA/gWIAO/fnll8ZpzDVYJkNNJRk6+HPNqMbZX96FcXU12hgW6eEaISKbi1oK+KsUfd3pwJ7VRGlC/++mVX4vZj4IWMW+i7uDZ1iesC/UGleqU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hUiDDge9; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hUiDDge9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E6B11F00A3A; Sun, 21 Jun 2026 17:18:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782062295; bh=OGWHEfZZb2DOcBU3QFV2hDPwohTz7bPGX7NOarWIQ8k=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=hUiDDge9qOtiRkbOIMHx6VZGGg1bjX1POvsJq5bafa4MzrdJ0TTNVnYRWnmLnriAp FzEUuXJ7IGBsoUdnxzvNTo6PZKH9v01GsruGsn0oaa0SXy3HkdGGkqrf9olS1ghDxK BsRTASY1gJ/wc4b7KrVatmGFMFr2Pq1ku90G0gAJeVwDz1k1lQLutzDIJ1E7kUzy20 q40Drb1ovZjra8mDCP4Ni4A45jzxSHxbKJwqOV9eG036TX0mLitjYxRcpG9MJR76vs WMlLVMIJVokfA//YLpVHgILnM/Xt+in0Ls7eA9Yt/ElcpUS1TwzcY/4Okk4hGH0++O vFOsONABDzzvg== Date: Sun, 21 Jun 2026 18:18:04 +0100 From: Jonathan Cameron To: Chris Morgan Cc: linux-iio@vger.kernel.org, andy@kernel.org, nuno.sa@analog.com, dlechner@baylibre.com, jean-baptiste.maneyrol@tdk.com, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, heiko@sntech.de, conor+dt@kernel.org, krzk+dt@kernel.org, robh@kernel.org, andriy.shevchenko@intel.com, Chris Morgan , Krzysztof Kozlowski Subject: Re: [PATCH V13 2/9] dt-bindings: iio: imu: icm42600: Add icm42607 Message-ID: <20260621181804.27b44942@jic23-huawei> In-Reply-To: <20260615172554.160910-3-macroalpha82@gmail.com> References: <20260615172554.160910-1-macroalpha82@gmail.com> <20260615172554.160910-3-macroalpha82@gmail.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 15 Jun 2026 12:25:45 -0500 Chris Morgan wrote: > From: Chris Morgan > > Add the ICM42607 and ICM42607P inertial measurement unit. > > This device is functionally very similar to the icm42600 series with a > very different register layout. The driver does not require an > interrupt for these specific chip revisions. This talks about how they are different from other parts already supported, but I think we need something on how they are different from each other. I'm kind of assuming one is a subset of the other? If that is the case the ideal might be the more complex part falling back to the simpler one. Thanks, Jonathan > > Signed-off-by: Chris Morgan > Reviewed-by: Krzysztof Kozlowski > --- > .../bindings/iio/imu/invensense,icm42600.yaml | 18 +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml b/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml > index 9b2af104f186..81b6e85decd5 100644 > --- a/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml > +++ b/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml > @@ -30,6 +30,8 @@ properties: > - invensense,icm42600 > - invensense,icm42602 > - invensense,icm42605 > + - invensense,icm42607 > + - invensense,icm42607p > - invensense,icm42622 > - invensense,icm42631 > - invensense,icm42686 > @@ -67,10 +69,24 @@ properties: > required: > - compatible > - reg > - - interrupts > > allOf: > - $ref: /schemas/spi/spi-peripheral-props.yaml# > + - if: > + properties: > + compatible: > + contains: > + enum: > + - invensense,icm42600 > + - invensense,icm42602 > + - invensense,icm42605 > + - invensense,icm42622 > + - invensense,icm42631 > + - invensense,icm42686 > + - invensense,icm42688 > + then: > + required: > + - interrupts > > unevaluatedProperties: false >