From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66C3933EAF9; Mon, 22 Jun 2026 18:19:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782152353; cv=none; b=EQXkeN3onOy9/fldx1D6yD7Ghq8bMXuvPyvBJcrw6EfweuyqhQte+iwb9hcqWkLn/h5/dcclFRX0DKDEjgNnajtr0k0kvOqhy7ogJ8YQCbKw5tiboy1Y3ZF9M7YkM9u72nqGH03KAqXt7tRSEjUcCgGk1Ri1yJQZnd4a6cCC3+E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782152353; c=relaxed/simple; bh=aKPfzKSh4kE5bd0323tvQMZuR4CGMJhZvfCO//1dm0k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oomhXPD5hBMTzyl6BYtrupE0mXfzVTz7jorrTJnhhYJ0fc+UlebG1Ec6B2AaajwTbVsh9btEFeiYXhzd3z07b6ZtvQ5WiMDgbuHW7r3WXESrbL19WMgVUO8d3M7+ioDlMmQ6vggFPVZdhkMjeDmm05mRU40467JOVf6j74UQ8vM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=W/QrQ8Gs; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="W/QrQ8Gs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3D82D1F000E9; Mon, 22 Jun 2026 18:19:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782152351; bh=XKlqJDn41xHqxzBssntuIwLv2qXiV/8MEgFKl/31tuA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=W/QrQ8GsogW7QyIXylJn27vxjfhXkXzLQahuKRQQthlkDvW6mIkGRGFoQ3mHpnOnl 8pFOXS8rAz6Jrdna6Qq63quSFnPeujpT2upF4iIggQQzxNQI+4WstblsTliuE06/qc JX1JWmRjRYM04WCNoQ6KG1nkuD8+1QNZVKGWaugrzWjklmz1z22Je/LyjALcT4QCUr Pz9PlT7YLynMWhP56ut9YH2jYvUTpBknBf38PhpAQ79ppC8mHtlUERsmrGQO0b+cYD MavyY5UKyd3nqs0WZMYVxHixpTJhwL19J36iDFNmuT27gjIU6lyx9iWpEer3nu6+21 iZqorFo426LSg== Date: Mon, 22 Jun 2026 18:19:09 +0000 From: Eric Biggers To: Bartosz Golaszewski Cc: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Vinod Koul , Thara Gopinath , Konrad Dybcio , Frank Li , Andy Gross , Harshal Dev , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Kuldeep Singh Subject: Re: [PATCH 0/5] Shikra: Add DT support for ice, rng and qce Message-ID: <20260622181909.GA1250822@google.com> References: <20260521-shikra_crypto_changse-v1-0-0154cc9cc0de@oss.qualcomm.com> <53b1fa61-9692-42fd-a295-98bbeacbcd9a@oss.qualcomm.com> <20260619164506.GA3223@sol> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jun 22, 2026 at 04:25:12AM -0400, Bartosz Golaszewski wrote: > On Fri, 19 Jun 2026 18:45:06 +0200, Eric Biggers said: > > On Fri, Jun 19, 2026 at 02:13:28PM +0530, Kuldeep Singh wrote: > >> On 21-05-2026 18:47, Kuldeep Singh wrote: > >> > This patchseries attempt to enable sdhc-ice, rng and qce on shikra > >> > platform similar to other platforms. > >> > > >> > Previously, the 3 dt-bindigs/DT changes were sent as individual series > >> > and with feedback received, clubbed them together as all belong to same > >> > crypto subsystem. > >> > > >> > Here's link to old patchsets. > >> > QCE: https://lore.kernel.org/lkml/20260515-shikra_qcrypto-v1-0-80f07b345c29@oss.qualcomm.com/ > >> > >> Hi Eric, > >> > >> As selftests issues for QCE are now fixed[1], so shikra series should be > >> good to proceed? as your concerns[2] are now addressed. > >> I am waiting for merge window to end and will send next rev post that. > >> > >> [1] > >> https://lore.kernel.org/linux-arm-msm/20260617-qce-fix-self-tests-v3-0-ecc2b4dedcfd@oss.qualcomm.com/ > >> [2] https://lore.kernel.org/lkml/20260522024912.GC5937@quark/ > > > > If you think that then it sounds like you need to read what I actually > > said. The fixes are appreciated but don't change the big picture. > > > > - Eric > > > > Eric, > > I mentioned it in another thread[1]. This series is not adding any new features > to the QCE driver, it describes the hardware. The SoC *does have* this IP and > no matter the state of the support in the kernel, there's nothing wrong in > extending the existing bindings and adding new dts nodes. > > Thanks, > Bartosz It enables the driver on a new platform. So it very much has a real effect. It's not just adding a hardware description without a user. - Eric