From: sashiko-bot@kernel.org
To: "Bjorn Andersson" <andersson@kernel.org>
Cc: robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 2/3] arm64: dts: qcom: glymur: Add Asus Zenbook A14 (UX3407NA)
Date: Tue, 23 Jun 2026 01:55:30 +0000 [thread overview]
Message-ID: <20260623015531.1B40E1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260623-zenbook-dts-v1-2-3f80f680381d@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Missing regulator configuration for `&smb2370_j_e2_eusb2_repeater` causing potential USB port failure.
--
commit 8c025a2ed8f0bc5c7861b62d7eff8a38ae127ae5
Author: Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>
arm64: dts: qcom: glymur: Add Asus Zenbook A14 (UX3407NA)
This commit adds device tree support for the Asus Zenbook A14 (UX3407NA),
built on the Qualcomm Glymur platform. It configures the typical platform
capabilities, including NVMe storage, screen, USB, and HDMI.
> diff --git a/arch/arm64/boot/dts/qcom/glymur-asus-zenbook-a14-ux3407na.dts b/arch/arm64/boot/dts/qcom/glymur-asus-zenbook-a14-ux3407na.dts
> new file mode 100644
> index 0000000000000..734fd3aea5d02
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/glymur-asus-zenbook-a14-ux3407na.dts
[ ... ]
> +&smb2370_k_e2_eusb2_repeater {
> + vdd18-supply = <&vreg_l15b_e0>;
> + vdd3-supply = <&vreg_l7b_e0>;
> +};
[ ... ]
> +&usb_0_hsphy {
> + vdd-supply = <&vreg_l3f_e0>;
> + vdda12-supply = <&vreg_l4h_e0>;
> +
> + phys = <&smb2370_j_e2_eusb2_repeater>;
> +
> + status = "okay";
> +};
[Severity: High]
Does this configuration miss the supplies for &smb2370_j_e2_eusb2_repeater?
The usb_0_hsphy node references &smb2370_j_e2_eusb2_repeater, but unlike the
k instance (&smb2370_k_e2_eusb2_repeater) shown above, the j instance does
not have its vdd18-supply and vdd3-supply configured in this file.
Without these configured, the driver falls back to dummy regulators. Since
vreg_l7b_e0 is not regulator-always-on and is only requested by the k
repeater, usb_0 might lose power and fail whenever usb_1 is suspended or
unused.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260623-zenbook-dts-v1-0-3f80f680381d@oss.qualcomm.com?part=2
next prev parent reply other threads:[~2026-06-23 1:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-23 1:31 [PATCH 0/3] arm64: dts: qcom: Introduce Asus Zenbook A14 (UX3407NA) Bjorn Andersson
2026-06-23 1:31 ` [PATCH 1/3] dt-bindings: arm: qcom: Add " Bjorn Andersson
2026-06-23 7:12 ` Krzysztof Kozlowski
2026-06-23 1:31 ` [PATCH 2/3] arm64: dts: qcom: glymur: " Bjorn Andersson
2026-06-23 1:55 ` sashiko-bot [this message]
2026-06-23 7:06 ` Konrad Dybcio
2026-06-23 1:31 ` [PATCH 3/3] firmware: qcom: scm: Allow QSEECOM on " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260623015531.1B40E1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox