From: Conor Dooley <conor@kernel.org>
To: Udaya Kiran Challa <challauday369@gmail.com>
Cc: tsbogend@alpha.franken.de, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, skhan@linuxfoundation.org,
me@brighamcampbell.com, linux-rtc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: dt-bindings: microchip,pic32mzda-sqi: Convert to DT schema
Date: Wed, 24 Jun 2026 17:48:36 +0100 [thread overview]
Message-ID: <20260624-charter-footless-9752837b15f3@spud> (raw)
In-Reply-To: <20260624061329.130468-1-challauday369@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 774 bytes --]
On Wed, Jun 24, 2026 at 11:43:29AM +0530, Udaya Kiran Challa wrote:
> + clocks:
> + maxItems: 2
Please make this an items list too (and drop the maxItems while you're
doing so).
pw-bot: changes-requested
> +
> + clock-names:
> + items:
> + - const: spi_ck
> + - const: reg_ck
> +examples:
> + - |
> + #include <dt-bindings/clock/microchip,pic32-clock.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + sqi1: spi@1f8e2000 {
And remove the unused label here.
Thanks,
Conor.
> + compatible = "microchip,pic32mzda-sqi";
> + reg = <0x1f8e2000 0x200>;
> + interrupts = <169 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&rootclk REF2CLK>, <&rootclk PB5CLK>;
> + clock-names = "spi_ck", "reg_ck";
> + };
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2026-06-24 16:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-24 6:13 [PATCH] spi: dt-bindings: microchip,pic32mzda-sqi: Convert to DT schema Udaya Kiran Challa
2026-06-24 16:48 ` Conor Dooley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260624-charter-footless-9752837b15f3@spud \
--to=conor@kernel.org \
--cc=challauday369@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=me@brighamcampbell.com \
--cc=robh@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox