From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6ED78314B8F; Wed, 24 Jun 2026 16:35:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782318937; cv=none; b=kdcCXd8bpIv0C/k88q1C/UZOa8tNFhaKcvFvFBKLm9XWkwekKtPByU9wWHQ8lUcxlvUhvUtCkodTGU2yhdlcKHI79DNwHA8IdacQynnxJQJw2gA3f3IeoON/Zh8g2q0N+sloDGbxynfVyS6fvQqyT1YrFZVeUO86p0cBchtcS/c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782318937; c=relaxed/simple; bh=iX+qCbQAUBwySYYfmw+ejL2gxBV075rCGNnrHZXjQes=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=o3SCLE9aNYkIsfvkGSwVvTgyVDaxjB1DPRkVwckKuetJ31dHeLD6ggYz9hPl3pm+mRFn3wSYKlW05LAJKww3kgUiKa7KvP+vPqkpunLqG97kQa2EW5tnPqTn4a1yfE+BQ04l0jiPTTVHFnII9OUdEr80ehK+T31ciCRzhYWs5JY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bdT/RH5T; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bdT/RH5T" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6E2981F00A3A; Wed, 24 Jun 2026 16:35:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782318936; bh=Z4kk0HrMKq/Q0UwY7zGO5VYhmHv7vIkGKvZwhgl85Fs=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=bdT/RH5TtEIJC+MX16Olkc11UeyGwkBOEePW0zTcpTt3miR7VL0hd20cyubpFKtnp 1NDBKOyvsHCqXz4j9th2dZ9+SVlQaCWTEG/Mr4mKnNJhN1FVqYkuX3vhI3WnUyI91O GvH0+0a10za14C9VHOjuK8ke0IWTf+dFA1zhnhXz6piMzdUEqAuXZIT/aRaLop7TR3 8qD0uJozVkaPbUgcIjrF0kyShqLSKEFx+9phWInc2j+bgVHmOKBhEAjMhiKZDvtTXd wdEUa39chaVXdhbx3EUclxGlHcFkLqIw4Xzn5ihUgcoDLC8nHZYPhBr+aN+0Ix/RqS 5OghWkvcBrthw== Date: Wed, 24 Jun 2026 17:35:30 +0100 From: Conor Dooley To: Janani Sunil Cc: Jonathan Cameron , Rodrigo Alencar <455.rodrigo.alencar@gmail.com>, Nuno =?iso-8859-1?Q?S=E1?= , Janani Sunil , Lars-Peter Clausen , Michael Hennerich , David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Jonathan Corbet , Shuah Khan , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Mark Brown Subject: Re: [PATCH v3 1/2] dt-bindings: iio: dac: Add AD5529R Message-ID: <20260624-shriek-condone-b33de4f596ec@spud> References: <20260621153330.79b6600c@jic23-huawei> <5u4dnsgxwcwie45f24cacyzf3dko4srhyyyhcpom6tsvhqtmpc@y7d7gmex6n7k> <5guhkvoxhkzevjm4b45hhk3772akpnz3givr3gb56x5ywamzyf@oiycreun4y62> <20260623155732.318f34f2@jic23-huawei> <9abc53d0-432f-48fc-9e21-4d9a3c5e129f@gmail.com> <20260624-decrease-protector-6c883bd1ac47@spud> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="WMWGjHXn8EdeWrF5" Content-Disposition: inline In-Reply-To: <20260624-decrease-protector-6c883bd1ac47@spud> --WMWGjHXn8EdeWrF5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 24, 2026 at 05:32:26PM +0100, Conor Dooley wrote: > > dac@0 { > > compatible =3D "adi,ad5529r-16"; > > reg =3D <0>; > > adi,device-addrs =3D <0 1>; >=20 > I think this should be put in the channel itself and made generic. I guess I should expand on that, putting it in the channel means it's not tied to some device-specific knowledge about when each device address is used. It should be generic because there are at least 3 devices, from 2 different vendors, that we know of, using the exact same scheme. > > reset-gpios =3D <&gpio0 87 GPIO_ACTIVE_LOW>; > > vdd-supply =3D <&vdd_reg>; > > hvdd-supply =3D <&hvdd_reg>; > >=20 > > channel@0 { reg =3D <0>; adi,output-range-microvolt =3D <0 50= 00000>; }; > > channel@16 { reg =3D <16>; adi,output-range-microvolt =3D <0 40= 000000>; }; > > }; > >=20 > > Does this look reasonable to everyone? > >=20 > > Regards, > > Janani Sunil > >=20 --WMWGjHXn8EdeWrF5 Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iHQEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCajwHUgAKCRB4tDGHoIJi 0nhLAP4wgrvst4IfZUk1vvpeL15upE92bqyykukZcM6dp2xoGwD1GqmVQmsZfafi heDcZmsOS6givl5H1Zm3U1zaYk5GCw== =8XW4 -----END PGP SIGNATURE----- --WMWGjHXn8EdeWrF5--