Re: [PATCH v3] dt-bindings: pwm: st,pwm: convert to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The example device tree node uses an outdated compatible string ('st,pwm') that violates the schema's own constraints ('st,sti-pwm'), causing dt_binding_check to fail.
--

commit d33b98ff54df0af652aa50944ad631d378f78938
Author: Charan Pedumuru <charan.pedumuru@gmail.com>

dt-bindings: pwm: st,pwm: convert to DT schema

This commit converts the STMicroelectronics STiH41x PWM/Capture controller
binding to DT schema. It changes the compatible string to "st,sti-pwm"
to match the hardware variant naming convention and removes pinctrl-names
from the required properties list.

> diff --git a/Documentation/devicetree/bindings/pwm/st,sti-pwm.yaml b/Documentation/devicetree/bindings/pwm/st,sti-pwm.yaml
> new file mode 100644
> index 0000000000000..c69073e79ce97
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/st,sti-pwm.yaml

[ ... ]

> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +    pwm@fe510000 {
> +        compatible = "st,pwm";

[Severity: Low]
Does this compatible string match the new schema?

The schema constraints above define the compatible property as "st,sti-pwm",
but the example node here still uses "st,pwm". Will this regression cause
the dt_binding_check validation to fail?

> +        reg = <0xfe510000 0x68>;
> +        interrupts = <GIC_SPI 128 IRQ_TYPE_LEVEL_HIGH>;
> +        #pwm-cells = <2>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260625-st-pwm-v3-1-ace9bff88529@gmail.com?part=1