Re: [PATCH v2 1/3] dt-bindings: media: qcom: Add JPEG encoder binding

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] The `clock-names` property is missing from the `required` list despite `clocks` being required and the driver relying on the names.
- [Medium] The commit message claims `reg-names` is documented as a property, but it is missing from the YAML schema.
--

commit d5b47be66fcc52e7570e1b138452c400f72abc6b
Author: Atanas Filipov <atanas.filipov@oss.qualcomm.com>

dt-bindings: media: qcom: Add JPEG encoder binding

This commit adds a device-tree binding for the Qualcomm JPEG encoder
hardware block present in SM8250 (Kona) SoCs.

>     Properties documented:
>     - compatible: qcom,sm8250-jenc
>     - reg / reg-names: single MMIO region named "jpeg"
>     - interrupts: single edge-triggered interrupt

[Severity: Medium]
The commit message claims reg-names is documented as a property, but it
is missing from the YAML schema below.

If a device tree uses reg-names = "jpeg" based on this documentation,
the device tree will fail schema validation because additionalProperties: false
is enforced. Should reg-names be added to the properties definition?

> diff --git a/Documentation/devicetree/bindings/media/qcom,jpeg-encoder.yaml b/Documentation/devicetree/bindings/media/qcom,jpeg-encoder.yaml
> new file mode 100644
> index 0000000000000..ab8d8951d21fa
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/qcom,jpeg-encoder.yaml
[ ... ]
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - interrupts

[Severity: High]
Does clock-names need to be included in the required list here?

If an incomplete device tree node provides clocks but omits clock-names,
the schema validation will silently pass since clock-names is not in the
required list.

At runtime, if the driver calls devm_clk_bulk_get_all(), it leaves the clock
id fields as NULL when clock-names is missing. The driver then iterating
over the clocks and calling strcmp(jenc->clks[c_idx].id, "core") would cause
a panic due to a NULL pointer dereference.

> +  - power-domains
> +  - iommus
> +  - interconnects
> +  - interconnect-names

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260625133828.3221781-1-atanas.filipov@oss.qualcomm.com?part=1