From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9DFB37C918; Thu, 25 Jun 2026 16:00:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782403234; cv=none; b=lU9pSnGOivAQHzcxJD3orj9s7pMz2vQAvZfLHeReECSbGt6436L11dJ5neBMpP7UxGtx7HEvhPVRQPmyv2Kn8W+hIxl5Hx+8Rg0LyuLq2uiHZqGtrmgLCrkLfACEGgQOkKRlXpiuht+eAVrr6M96NOf1l3s84WUnOkBUJWM8SII= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782403234; c=relaxed/simple; bh=lX9jmqEcAPhUFJ+NWeKitWgG6t+ViDMhClqAYMxj1pY=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=sI7VjOmAHpVhVsLVFxYo+oEMYkGyogIBkiil3Jv8vgIWtr2QwTMtPzaUj+hWPB/ZNKSKCpG9W5AmsNIUm2n3GRk9NFd1ss44q3h8vL85xf7b58obwVxuD7lda4F1zS0aPvDzo3md2Nitq8s9PQn/KZ5tL3tA7QsYGO9OzTA+WCA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=L4cf7zKs; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="L4cf7zKs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 99E8B1F000E9; Thu, 25 Jun 2026 16:00:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782403230; bh=hdFiQo9zgZ8hojf5cEoI/wKiDQNM6T4g1BqlyxdyxBM=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=L4cf7zKsoswdZbswVOo6Qngv9JRoVASr/7v7nyAhXv0GhbQAEvNTBBFqzu6oPrC8e l4q86xxSNy3PKuEX1iJdYwApgIG+GJaRTiBY/SaDP56GxQTeWVtPtv9Fp7Q4Rhppvq s30LAmCC6Hf9hKSO8N/erRMOI5RZDbwmlfnEKV/b9AyWuylfVFcy+WlI23IZ5ZfUKv N8i7MCW69SS7hwe2cSey/JJoG8InkAiljv4/LQwCZSvDprBpBhyuJ0LWtDk+G7oxQx wN0SaXyQHUrT1IAgYg43R/LbA2IPQ89GaP/kfRVSbaZTNa/aGMHGU3G0YwSPDgtQ9l 2Qk1JE+GapOCA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v14 2/5] dt-bindings: remoteproc: imx_rproc: Add "rpmsg" subnode support Reply-To: sashiko-reviews@lists.linux.dev To: "Shenwei Wang" Cc: conor+dt@kernel.org, robh@kernel.org, Frank.Li@kernel.org, imx@lists.linux.dev, devicetree@vger.kernel.org In-Reply-To: <20260625155432.815185-3-shenwei.wang@oss.nxp.com> References: <20260625155432.815185-1-shenwei.wang@oss.nxp.com> <20260625155432.815185-3-shenwei.wang@oss.nxp.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 25 Jun 2026 16:00:28 +0000 Message-Id: <20260625160029.99E8B1F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 3 potential issue(= s) to consider: - [Medium] The `gpio-rpmsg.yaml` binding adds GPIO and interrupt controller= provider capabilities but fails to list `gpio-controller` and `interrupt-c= ontroller` in its `required` properties array. - [Medium] The `rpmsg` node schema hardcodes `rpmsg-io` as the only allowed= subnode, contradicting the commit message's description of flexible channe= l names. - [Low] The `patternProperties` regex used for matching GPIO subnodes in `f= sl,imx-rproc.yaml` is missing a start-of-string anchor (`^`). -- commit e02180a974397446bfafe8bc43641010b7365078 Author: Shenwei Wang dt-bindings: remoteproc: imx_rproc: Add "rpmsg" subnode support This commit adds device tree binding support for RPMSG GPIO controllers exposed by a remote processor. It introduces a generic RPMSG GPIO controller schema and updates the fsl,imx-rproc binding to support a new rpmsg subnode container for these channels. > diff --git a/Documentation/devicetree/bindings/gpio/gpio-rpmsg.yaml b/Doc= umentation/devicetree/bindings/gpio/gpio-rpmsg.yaml > new file mode 100644 > index 0000000000000..6c78b6850321c > --- /dev/null > +++ b/Documentation/devicetree/bindings/gpio/gpio-rpmsg.yaml [ ... ] > + "#interrupt-cells": > + const: 2 > + > +required: > + - compatible > + - reg > + - "#gpio-cells" > + - "#interrupt-cells" [Severity: Medium] Should gpio-controller and interrupt-controller be included in this required list? The binding adds GPIO and interrupt controller provider capabilities, so omitting them might allow incomplete device tree nodes to pass validatio= n. > + > +allOf: > + - $ref: /schemas/gpio/gpio.yaml# > + > +unevaluatedProperties: false > diff --git a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.y= aml b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml > index ce8ec0119469c..aea33205a881a 100644 > --- a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml > +++ b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml [ ... ] > @@ -85,6 +85,34 @@ properties: > This property is to specify the resource id of the remote processo= r in SoC > which supports SCFW > =20 > + rpmsg: > + type: object > + additionalProperties: false > + description: > + Represents the RPMSG bus between Linux and the remote system. Cont= ains > + a group of RPMSG channel devices running on the bus. > + > + properties: > + rpmsg-io: > + type: object > + additionalProperties: false [Severity: Medium] The commit message states "The name of each subnode corresponds to the channel name as defined by the remote processor". Does hardcoding rpmsg-io as a property and setting additionalProperties to false unintentionally restrict the schema from allowing flexible channel names? > + properties: > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 0 > + > + patternProperties: > + "gpio@[0-9a-f]+$": > + type: object > + $ref: /schemas/gpio/gpio-rpmsg.yaml# > + unevaluatedProperties: false [Severity: Low] Does this regex need a start-of-string anchor (^)? Without it, could this unintentionally match any node name that ends in gpio@[0-9a-f]+? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260625155432.8151= 85-1-shenwei.wang@oss.nxp.com?part=3D2