From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1C893F8ECA; Fri, 26 Jun 2026 16:09:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782490145; cv=none; b=g/iQH9yW7YVkgCVNPTOQAnGdR40K7Trxz4O3OFqdhv/WfqN5LairBwAIq9zsCIEkYcGYtco0yyCf9GzPa3VuuCZ2YAwYOUM5Lh/g6NH8ZDw0j/7sU4ac1cdjwll13irCAfz1Bl0iWp+zcDsHLNrZRxtw8ENW5Opwvd6REBpDaO4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782490145; c=relaxed/simple; bh=L1WN68bsiHX/jymHG2SJmwFEibVFKXVxLGOGGfsJtFQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uUTnsiHDZhJPF4RjBttKH+9I0ZfwazrCboI5jku4DswGk1b38KU9H3DK4YM0aCKB20hhGtw2Tgw7vwgn7CHISHMvXao0rBcsKdf9/Nz0seSsdknbnDbYBw7IHqCy5cP0H4J1RjCdBn8C9Co/qlnOaChsctgib5YRSSdwBWNkP8g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iQZOZQVl; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iQZOZQVl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EBB561F000E9; Fri, 26 Jun 2026 16:08:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782490143; bh=Fx3tciuHyjlkIBIBNEBD+s8vVCSZdcyUAOaq3PBg7Ps=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=iQZOZQVlKUG92jlBmV7tChmBKGdzefozF27KNgP05RnlO6UgoAp/85WdimyWCLTJN ZFGfCICs2z+ZEzedTCQH+Nje6VFRH6R1EzPqC+LuVN+owy7Nivt7G3oHHNYIGfYK77 aNv6xDG5Pb0kYE8UfgrAV9vC/wfbZSLC+LuOi1SoZrmhLHK+5iUJBJ5GJxcLsJY3Oj hdcnrobdPhRHYU1nMv6tqfCHXew1xsF5yJR5PRizgB1N+mvPkDcru3Fz1GyAwPhzDY 47GHd4+qSlkAW6Mc+Q2uwWR0JFH/3xYj7438e/s27fcK6u74CvijZNWFKNh1tCOT/7 rNF/9jor31ViQ== Date: Fri, 26 Jun 2026 17:08:53 +0100 From: Conor Dooley To: Drew Fustini Cc: Adrien Ricciardi , Alexandre Ghiti , Atish Kumar Patra , Atish Patra , Babu Moger , Ben Horgan , Borislav Petkov , Chen Pei , Conor Dooley , Conor Dooley , Dave Hansen , Dave Martin , Fenghua Yu , Gong Shuai , Gong Shuai , guo.wenjia23@zte.com.cn, James Morse , Kornel =?utf-8?Q?Dul=C4=99ba?= , Krzysztof Kozlowski , liu.qingtao2@zte.com.cn, Liu Zhiwei , Palmer Dabbelt , Paul Walmsley , Peter Newman , Radim =?utf-8?B?S3LEjW3DocWZ?= , Reinette Chatre , Rob Herring , Samuel Holland , Sebastian Andrzej Siewior , Tony Luck , Vasudevan Srinivasan , Ved Shanbhogue , Weiwei Li , yunhui cui , linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, x86@kernel.org, devicetree@vger.kernel.org, linux-rt-devel@lists.linux.dev, linux-doc@vger.kernel.org Subject: Re: [PATCH v2 7/8] dt-bindings: riscv: Add generic CBQRI controller binding Message-ID: <20260626-refining-thus-6635a0f7c5cd@spud> References: <20260624-dfustini-atl-sc-cbqri-dt-v2-0-2f8049fd902b@kernel.org> <20260624-dfustini-atl-sc-cbqri-dt-v2-7-2f8049fd902b@kernel.org> <20260625-cupbearer-failing-9ce0abf97b93@spud> <20260626-immobile-staining-c825a86bd613@spud> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="fQnCqX8ZQXXtFFbN" Content-Disposition: inline In-Reply-To: --fQnCqX8ZQXXtFFbN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 26, 2026 at 09:05:02AM -0700, Drew Fustini wrote: > On Fri, Jun 26, 2026 at 04:44:56PM +0100, Conor Dooley wrote: > > On Thu, Jun 25, 2026 at 12:21:52PM -0700, Drew Fustini wrote: > > > On Thu, Jun 25, 2026 at 05:19:28PM +0100, Conor Dooley wrote: > > > > On Wed, Jun 24, 2026 at 06:38:35PM -0700, Drew Fustini wrote: > > > > > Document the generic compatibles for capacity and bandwidth contr= ollers > > > > > that implement the RISC-V CBQRI specification. The binding also > > > > > describes the common riscv,cbqri-rcid and riscv,cbqri-mcid proper= ties, > > > > > and the optional riscv,cbqri-cache phandle that links a capacity > > > > > controller to the cache whose capacity it allocates. > > > > >=20 > > > > > Assisted-by: Claude:claude-opus-4-8 > > > > > Co-developed-by: Adrien Ricciardi > > > > > Signed-off-by: Adrien Ricciardi > > > > > Signed-off-by: Drew Fustini > > > > > --- > > > > > .../devicetree/bindings/riscv/riscv,cbqri.yaml | 97 ++++++++= ++++++++++++++ > > > > > MAINTAINERS | 1 + > > > > > 2 files changed, 98 insertions(+) > > >=20 > > > Thanks for the review. > > >=20 > > > [..] > > > > > +properties: > > > > > + compatible: > > > > > + oneOf: > > > > > + - items: > > > > > + - description: Tenstorrent Ascalon Shared Cache > > > > > + const: tenstorrent,ascalon-sc-cbqri > > > > > + - const: riscv,cbqri-capacity-controller > > > > > + - enum: > > > > > + - riscv,cbqri-capacity-controller > > > > > + - riscv,cbqri-bandwidth-controller > > > >=20 > > > > Please modify this, as has been done for other riscv spec related > > > > bindings, to let people get away without using device-specific > > > > compatibles. > > > >=20 > > > > In this case, you can just delete the first entry from this enum, s= ince > > > > it already has a user and only have to implement this feedback for = the > > > > second entry. > > >=20 > > > Would this work? > > >=20 > > > properties: > > > compatible: > > > oneOf: > > > - items: > > > - enum: > > > - tenstorrent,ascalon-sc-cbqri # Tenstorrent Ascalon Sh= ared Cache > > > - const: riscv,cbqri-capacity-controller > > > - items: > > > - {} > > > - const: riscv,cbqri-bandwidth-controller > >=20 > >=20 > > Should do, yes. I question the need for a comment though, seems pretty > > evident from the compatible what it is. >=20 > I was thinking people may not know that 'sc' is the Shared Cache. I > probably should have shortend the comment to 'Ascalon Shared Cache'. > Anyways, I can drop it. Or call the device "ascalon-shared-cache-controller"! --fQnCqX8ZQXXtFFbN Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCaj6kFQAKCRB4tDGHoIJi 0ngnAP4+tZ3gpzZDlXPPujWnhu7Hv/STeRXLHNaHQpmbLVywZQD/fdcUyQlrk7zr qDRq2QQ5uj/CfqxhWarfWX1g1+enBwE= =RBQ8 -----END PGP SIGNATURE----- --fQnCqX8ZQXXtFFbN--