From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 069653CAE7F; Fri, 26 Jun 2026 05:50:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782453045; cv=none; b=HfJFJAyPREd4/5tRBcA2S9ns8/Qxm21qPjdbaHLlIbgzGwB44nztY3kkohAZ9T5bzzAhKrjEzsHSQ9KllVBltciRFu8jaTfOB5y+AhXswvN6IMs9rPW0m0CyFSm4yNylPLmEEqewMZReUVCx5GZoustfqqCk24W//bCK/2vJU3k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782453045; c=relaxed/simple; bh=BP6o0ae/B0exO8m91oeCU4rd8de0HLBfgYtGzgId+1o=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=Fjldxw96JLVabNGEVqa3JkPNRRBl7MXP5PqvI001NDLjn9W8JTOU1WDGOK+5vpxULb77XYEmKxtMSYHYYuYabBPE2d5h4dAR5b+qZG8tiB8YmhjD04NqjJIFrn0PEdUCk1tad5jeRtws9OIRpyBI8XBLR8DnQh2piHrF8Z618tU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=lfjnuEid; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lfjnuEid" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 061BD1F000E9; Fri, 26 Jun 2026 05:50:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782453033; bh=fpqguDEqtAYjCGwIjtf7qbbFYvPiXQsaNg2WmGUEkWA=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=lfjnuEidXn2ukIdD7bnTLw2mDS+HxiUP5ADnYTRfDFK1ENv7TV+pRu7A6aYO7bAng elT3Sh1yQxIXWNj5mXbJUm0MDdc2txsoVfJ9+0D1pZ4JKFMBUH+EdTGyWC6Zy53PJJ ioAJBBDnyDC2PvjeeLt3HLPlRQwDATv2xY4mq4k9Z85Dfb7e9d85/OwsGfIoQ05VR8 O7IJkuiJYcuE+ZkerdGuly7FNJuowMeR8q7yTTgWdG+R3Q43H+z4IMCg34RGviEYw9 DRKED1/T6Pzlh3KXMw9hYLz7a5mn3FP3dVAvCnzedsQYtVj0B0zZsypVLGDrc7gzm5 3g2d/ywstPjOQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v9 1/3] dt-bindings: dma: Add Amlogic A9 SoC DMA Reply-To: sashiko-reviews@lists.linux.dev To: "Xianwei Zhao via B4 Relay" Cc: Frank.Li@kernel.org, robh@kernel.org, neil.armstrong@linaro.org, conor+dt@kernel.org, vkoul@kernel.org, linux-amlogic@lists.infradead.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org In-Reply-To: <20260626-amlogic-dma-v9-1-558d672c4a95@amlogic.com> References: <20260626-amlogic-dma-v9-0-558d672c4a95@amlogic.com> <20260626-amlogic-dma-v9-1-558d672c4a95@amlogic.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 26 Jun 2026 05:50:32 +0000 Message-Id: <20260626055033.061BD1F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 3 potential issue(= s) to consider: - [Low] Global dt-binding header defines generic 'DMA_TX' and 'DMA_RX' macr= os, risking namespace collisions. - [Low] The `#dma-cells` property lacks a description explaining the layout= and purpose of its 2 cells. - [Low] Missing space before the opening brace in the device tree example n= ode. -- commit a7b4f5e4e6207e7134f0b399abc853db92908381 Author: Xianwei Zhao dt-bindings: dma: Add Amlogic A9 SoC DMA This commit adds device tree binding documentation for the Amlogic A9 SoC general-purpose DMA controller. It also introduces a new header file contai= ning specific property values for this controller. > diff --git a/Documentation/devicetree/bindings/dma/amlogic,a9-dma.yaml b/= Documentation/devicetree/bindings/dma/amlogic,a9-dma.yaml > new file mode 100644 > index 0000000000000..efd7b2602c336 > --- /dev/null > +++ b/Documentation/devicetree/bindings/dma/amlogic,a9-dma.yaml [ ... ] > @@ -0,0 +1,65 @@ > +properties: > + compatible: > + const: amlogic,a9-dma [ ... ] > + clock-names: > + const: sys > + > + '#dma-cells': > + const: 2 [Severity: Low] Is a description needed for this `#dma-cells` property to explain the layout and purpose of its 2 cells? Without it, device tree writers won't have documentation clarifying which cell represents the channel ID and which represents the direction. > + > + dma-channels: > + maximum: 64 [ ... ] > +examples: > + - | > + #include > + dma-controller@fe400000{ [Severity: Low] This isn't a bug, but should there be a space before the opening brace here? Normally it is formatted as `dma-controller@fe400000 {`. > + compatible =3D "amlogic,a9-dma"; > + reg =3D <0xfe400000 0x4000>; > + interrupts =3D ; > + clocks =3D <&clkc 45>; > + #dma-cells =3D <2>; > + dma-channels =3D <28>; > + }; > diff --git a/include/dt-bindings/dma/amlogic,a9-dma.h b/include/dt-bindin= gs/dma/amlogic,a9-dma.h > new file mode 100644 > index 0000000000000..c59c2fd4b9561 > --- /dev/null > +++ b/include/dt-bindings/dma/amlogic,a9-dma.h > @@ -0,0 +1,8 @@ > +/* SPDX-License-Identifier: (GPL-2.0 OR MIT) */ > + > +#ifndef __DT_BINDINGS_DMA_AMLOGIC_DMA_H__ > +#define __DT_BINDINGS_DMA_AMLOGIC_DMA_H__ > + > +#define DMA_TX 0 > +#define DMA_RX 1 [Severity: Low] Could these macro names lead to namespace collisions since they lack a vend= or or SoC prefix? These names are already widely used across the kernel, and defining them generically in a global dt-bindings header might cause preprocessor collisions and build failures for any driver or DTS file that includes this header. > +#endif /* __DT_BINDINGS_DMA_AMLOGIC_DMA_H__ */ --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260626-amlogic-dm= a-v9-0-558d672c4a95@amlogic.com?part=3D1