Re: [PATCH v2 2/3] arm64: dts: qcom: Add HP EliteBook X G2q 14 AI

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `usb_2` DWC3 controller and its high-speed PHY are explicitly enabled despite having no physical connection and being completely unused.
--

commit cd918ca13e11bd1a5f9fec450e22054021db1490
Author: Jason Pettit <jason.pettit@oss.qualcomm.com>

arm64: dts: qcom: Add HP EliteBook X G2q 14 AI

Add board support for the HP EliteBook X G2q 14" Next Gen AI PC.
This enables various device tree nodes including the HDMI output,
eUSB2, NVMe, and other peripherals on the Snapdragon X2 Elite platform.

> diff --git a/arch/arm64/boot/dts/qcom/glymur-hp-elitebook-x-g2q.dts b/arch/arm64/boot/dts/qcom/glymur-hp-elitebook-x-g2q.dts
> new file mode 100644
> index 0000000000000..b3e351ed7ea7e
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/glymur-hp-elitebook-x-g2q.dts

[ ... ]

> +/*
> + * usb_2 is a fixed DP-to-HDMI bridge; its SID-11 eUSB2 repeater is
> + * firmware-gated and never probes, so leave smb2370_l disabled.
> + */
> +&smb2370_l_e2 {
> +	status = "disabled";
> +};

[ ... ]

> +/*
> + * usb_2 is not exposed as a connector; its combo-PHY's DP lanes drive the
> + * chassis HDMI bridge (see hdmi-bridge).
> + */
> +&usb_2 {
> +	maximum-speed = "high-speed";
> +
> +	phys = <&usb_2_hsphy>;
> +	phy-names = "usb2-phy";
> +
> +	status = "okay";
> +};
> +
> +&usb_2_hsphy {
> +	vdd-supply = <&vreg_l3f_e0_0p91>;
> +	vdda12-supply = <&vreg_l4h_e0_1p2>;
> +
> +	status = "okay";
> +};

[Severity: Medium]
Since this port is used purely for DisplayPort-to-HDMI output via the
combo-PHY DP lanes, and the eUSB2 repeater is explicitly noted as never
probing, should the usb_2 DWC3 controller and usb_2_hsphy be enabled here?

Leaving status = "okay" for the unused DWC3 controller and its high-speed PHY
binds drivers that will consume resources like memory and IRQs unnecessarily
for hardware that isn't connected.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260625-glymur-send-v2-0-00905324ffbf@oss.qualcomm.com?part=2