Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: peter.wang@mediatek.com
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v1 1/2] Documentation: dt: reset: add mediatek,syscon-reset binding
Date: Fri, 26 Jun 2026 07:53:58 +0000	[thread overview]
Message-ID: <20260626075358.C19D51F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260626074820.2537772-2-peter.wang@mediatek.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The YAML binding schema is missing the mandatory `$id` field.
--

commit 010ce9609c338d8282471debb7c3cd606956e201
Author: Peter Wang <peter.wang@mediatek.com>

Documentation: dt: reset: add mediatek,syscon-reset binding

This commit adds Device Tree binding documentation for the MediaTek SYSCON 
reset controller. The binding describes a reset controller that is part of 
a MediaTek SYSCON MFD block and manages multiple reset lines via the 
mediatek,reset-bits property.

> diff --git a/Documentation/devicetree/bindings/reset/mediatek,syscon-reset.yaml b/Documentation/devicetree/bindings/reset/mediatek,syscon-reset.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/reset/mediatek,syscon-reset.yaml
> @@ -0,0 +1,93 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$schema: http://devicetree.org/meta-schemas/core.yaml#

[Severity: Medium]
Is the mandatory $id field missing from this schema definition?

Without the $id field, the schema cross-reference system ($ref resolution)
can break, and dt_binding_check might silently skip validation or report
misleading errors. Should it be added to the top-level schema header?

> +
> +title: MediaTek SYSCON Reset Controller

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260626074820.2537772-1-peter.wang@mediatek.com?part=1

       reply	other threads:[~2026-06-26  7:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260626074820.2537772-1-peter.wang@mediatek.com>
     [not found] ` <20260626074820.2537772-2-peter.wang@mediatek.com>
2026-06-26  7:53   ` sashiko-bot [this message]
     [not found] ` <20260626074820.2537772-3-peter.wang@mediatek.com>
2026-06-26  8:00   ` [PATCH v1 2/2] reset: mediatek: add syscon-based reset controller driver sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260626075358.C19D51F00A3A@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=peter.wang@mediatek.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox