Re: [PATCH v2 4/8] ARM: tegra: Convert to new media orientation definitions

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit introduces an undefined macro `MEDIA_ORIENTATION_REAR`, causing a Device Tree Compiler (dtc) build failure.
--

commit 26c9ba57e237b4ebfdbb6dbf2af353106c11c695
Author: Kieran Bingham <kieran.bingham@ideasonboard.com>

ARM: tegra: Convert to new media orientation definitions

The commit updates the NVIDIA device trees to use new media orientation
definitions instead of hardcoded integer values for video interface devices.

> diff --git a/arch/arm/boot/dts/nvidia/tegra30-lg-x3.dtsi b/arch/arm/boot/dts/nvidia/tegra30-lg-x3.dtsi
> index 60e8a19aa70ec..c58e3026a115e 100644
> --- a/arch/arm/boot/dts/nvidia/tegra30-lg-x3.dtsi
> +++ b/arch/arm/boot/dts/nvidia/tegra30-lg-x3.dtsi
[ ... ]
> @@ -1216,7 +1217,7 @@ rear-camera@10 {
>  			dvdd-supply = <&vdd_1v2_rear>;
>  			avdd-supply = <&vdd_2v7_rear>;
>  
> -			orientation = <1>; /* Rear camera */
> +			orientation = <MEDIA_ORIENTATION_REAR>;

[Severity: Low]
Will this cause a Device Tree Compiler build failure?

Looking at the dt-bindings/media/video-interface-devices.h header, it
defines MEDIA_ORIENTATION_FRONT, MEDIA_ORIENTATION_BACK, and
MEDIA_ORIENTATION_EXTERNAL.

Since MEDIA_ORIENTATION_REAR is undefined, the C preprocessor will leave it
as an unexpanded token, which will cause a syntax error when dtc parses it.
Could this be updated to use MEDIA_ORIENTATION_BACK instead?

>  			rotation = <90>;
>  
>  			nvmem = <&m24c08>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260626-kbingham-orientation-v2-0-47178be927b4@ideasonboard.com?part=4