From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFD9D3FCB05 for ; Fri, 26 Jun 2026 16:14:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782490499; cv=none; b=GZbBePjKQWstB0bDd1iq1/VVejX/6URGZ/6XDiJOG3cWc4KAARZdT6qEau9HKKxDg8CxHgoCAUts55y7JmDtQ+HVjZyKEaZpcciJKesebykd7WK6KntTcxbtG4kVy+hr+LfrTPqDlJO2weWDYyseXDhiqYMu47CYw5wMCDStSvI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782490499; c=relaxed/simple; bh=jdxjaXz/6sVteoOUV7xUdoqzpMFR6emfLJ7qTdI2yVM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lwWBThdkin6ASJgJXpKIuaELeostgSuFTIhY8WSS22Ul9N1e6bMLTgVDwY/xp9RCLgWUm1sQ5SKwC5fIfY67I/PYq7MdHNSAn4edJUvxumWuhwakHy56t8R1raEuykVJfmCAs6RrsvWA043/OvW6JeTgk+YSFTg2THxObjqUNcU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QjMP/7st; arc=none smtp.client-ip=209.85.210.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QjMP/7st" Received: by mail-ot1-f51.google.com with SMTP id 46e09a7af769-7e94cd6f99aso1286543a34.3 for ; Fri, 26 Jun 2026 09:14:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782490497; x=1783095297; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fCSrfQX0Rn0O34RkVnCubJXjgpd2VYZ6SU0CwsYowUU=; b=QjMP/7stqpQWw+s77YTLJWqgha9cg41PSS4By9N4XY+GkMeVIMcvCZUARtjnSQTSrq uDu0qpWO27B+1fUZrULQsHSBlpxHnwTlcqxgt3U5QU3hGueSUNYvIvXSiDr7WsabSGII 6zP/smiDHA4Ai7hkhAoiToFceuhLTW3AGvXB7C6O9g4Sx6QkH0AsgyYCNjntkfKU7F91 BVCEarcFwvJCH3CzJUvB4pqsOMVhjmig0cI1JsHucqZn5RaCh+ViJBzsNDcIStDQT3Qb FPvYIvdiQ37nGVJ46H6GVi1wQ6kUw1TQ9EHsr6Doo4r9wViBu6vGZr4Cflr5gniTBEQg ZUZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782490497; x=1783095297; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=fCSrfQX0Rn0O34RkVnCubJXjgpd2VYZ6SU0CwsYowUU=; b=CxGvXh2rWymzZhBrBLp8mqCGHUGeUKaZ2NpDv7tvB8X3wJlmQcExNVZwU7rDb7RBot TUYEOPIq81wVjRZ0anHYTD9MPBiGOskDPbYbdEcesA73pwtkT8fCyTrTGlI4X5bOiTMr Ipb3wLH7PLPEkoNCk9qk9VT2zrT1v9WiTDgJa/M9tdgjYOcTMcGKXnWKF5phxnRVmDzJ PLz3mvMPLvM2xKzEVH2qdZht8hBpr+Yplk6bHkXeTWnKo21L1iTQtD9rH+4NPW/G45s+ CxHzwWNSOTVAQPABuLD7VAA733loWvHNJK5rKx9817V9vwA2DG2z69zfgwSCVNB2UxTq TB4g== X-Forwarded-Encrypted: i=1; AFNElJ+CEU+xJ/4MJ6Pzp9QE2Np7eO3/N5gqXQnmrsPCZEvYC/ktIa2C9Lp1Ktjnm8gdcEgymVKP7DVNmv5D@vger.kernel.org X-Gm-Message-State: AOJu0YwHM8dQEewkpN/snkohod+ajP9GFTrKURI9l3Ob7NNGGn8YreDQ bCpsTbkcnwPW//lHJomvyUj5UlsIEeErnvLsfSN3ucKbD6cdvrJyUoL/77F4o3ec X-Gm-Gg: AfdE7clqpFpsOJSiNuh9eSoubPww6tJhhcdjZeHzrfnP2e191a3EshkLNAFiAfOfHsw 6zmf0B0JbAulgjRnmFNozkn9ccktweJ2fj0dk4Hg+qhHtztye2LcRP+IEq9bzXhiZc6pavqIgHu G87jI3X4CLv9orEAVNhANQctnMsjNJ7g7gl80pmIGt5i4bPKqHdS2QFSm1H4iCJYL+UNIZokWwy HbzwM8ug1BuTo2wNvunhTqdlsWdieqwe3h4RrMTfmgj4hiz0BVrZJzXk/llp6/D3jpU8KLcKe7D wwOj/rmZHF95OXlg0jzdtKC7s2ZBl0Ub98BDO0YIbH5RKGxoU7hr+khHVOVNjGCl6XrvBn1pn7o akdZz4TqjIXOb85TXYApXeeJ8hoSQ2fbTrW2kagckhLcn7h04/v1YGNTfMU88dKMKyaUGKoHhkL O3eiGNmvyXNZ8= X-Received: by 2002:a05:6830:610d:b0:7dc:df37:844b with SMTP id 46e09a7af769-7e99bf3f3e7mr6787284a34.4.1782490496989; Fri, 26 Jun 2026 09:14:56 -0700 (PDT) Received: from localhost.localdomain ([2600:1700:fb0:1bc0::54]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7e9aa579235sm1970211a34.1.2026.06.26.09.14.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jun 2026 09:14:56 -0700 (PDT) From: Chris Morgan To: linux-iio@vger.kernel.org Cc: andy@kernel.org, nuno.sa@analog.com, dlechner@baylibre.com, jic23@kernel.org, jean-baptiste.maneyrol@tdk.com, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, heiko@sntech.de, conor+dt@kernel.org, krzk+dt@kernel.org, robh@kernel.org, andriy.shevchenko@intel.com, Chris Morgan Subject: [PATCH V15 5/9] iio: imu: inv_icm42607: Add PM support for icm42607 Date: Fri, 26 Jun 2026 11:12:26 -0500 Message-ID: <20260626161230.93069-6-macroalpha82@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260626161230.93069-1-macroalpha82@gmail.com> References: <20260626161230.93069-1-macroalpha82@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Chris Morgan Add power management support for the ICM42607 device driver. Signed-off-by: Chris Morgan --- drivers/iio/imu/inv_icm42607/inv_icm42607.h | 17 ++ .../iio/imu/inv_icm42607/inv_icm42607_core.c | 146 ++++++++++++++++++ .../iio/imu/inv_icm42607/inv_icm42607_i2c.c | 1 + .../iio/imu/inv_icm42607/inv_icm42607_spi.c | 1 + 4 files changed, 165 insertions(+) diff --git a/drivers/iio/imu/inv_icm42607/inv_icm42607.h b/drivers/iio/imu/inv_icm42607/inv_icm42607.h index 88d35323bade..219cfcf7ac99 100644 --- a/drivers/iio/imu/inv_icm42607/inv_icm42607.h +++ b/drivers/iio/imu/inv_icm42607/inv_icm42607.h @@ -10,6 +10,7 @@ #include #include #include +#include #include #include #include @@ -118,12 +119,19 @@ struct inv_icm42607_hw { u8 whoami; }; +struct inv_icm42607_suspended { + enum inv_icm42607_sensor_mode gyro; + enum inv_icm42607_sensor_mode accel; +}; + /** * struct inv_icm42607_state - driver state variables * @hw: Hardware specific data. * @lock: lock for serializing multiple registers access. * @map: regmap pointer. * @vddio_supply: I/O voltage regulator for the chip. + * @vddio_en: I/O voltage status for runtime PM. + * @suspended: suspended sensors configuration. * @conf: chip sensors configurations. * @orientation: sensor chip orientation relative to main hardware. */ @@ -132,6 +140,8 @@ struct inv_icm42607_state { struct mutex lock; struct regmap *map; struct regulator *vddio_supply; + bool vddio_en; + struct inv_icm42607_suspended suspended; struct inv_icm42607_conf conf; struct iio_mount_matrix orientation; }; @@ -351,11 +361,18 @@ struct inv_icm42607_state { #define INV_ICM42607_GYRO_STOP_TIME_US (45 * USEC_PER_MSEC) #define INV_ICM42607_TEMP_STARTUP_TIME_US 77 +/* + * Suspend delay assumed from other icm42600 series device, not + * documented in datasheet. + */ +#define INV_ICM42607_SUSPEND_DELAY_MS 2000 + typedef int (*inv_icm42607_bus_setup)(struct inv_icm42607_state *); extern const struct regmap_config inv_icm42607_regmap_config; extern const struct inv_icm42607_hw inv_icm42607_hw_data; extern const struct inv_icm42607_hw inv_icm42607p_hw_data; +extern const struct dev_pm_ops inv_icm42607_pm_ops; int inv_icm42607_core_probe(struct regmap *regmap, const struct inv_icm42607_hw *hw, diff --git a/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c b/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c index 9b82a0499d35..738970ed5c66 100644 --- a/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c +++ b/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c @@ -4,16 +4,20 @@ */ #include +#include #include #include #include #include #include +#include #include #include +#include #include #include #include +#include #include #include "inv_icm42607.h" @@ -102,6 +106,71 @@ const struct inv_icm42607_hw inv_icm42607p_hw_data = { }; EXPORT_SYMBOL_NS_GPL(inv_icm42607p_hw_data, "IIO_ICM42607"); +static int inv_icm42607_set_pwr_mgmt0(struct inv_icm42607_state *st, + enum inv_icm42607_sensor_mode gyro, + enum inv_icm42607_sensor_mode accel) +{ + unsigned int oldaccel, oldgyro; + unsigned int sleepval_us = 0; + unsigned int val; + s64 disable_wait; + int ret; + + ret = regmap_read(st->map, INV_ICM42607_REG_PWR_MGMT0, &val); + if (ret) + return ret; + + oldaccel = FIELD_GET(INV_ICM42607_PWR_MGMT0_ACCEL_MODE_MASK, val); + oldgyro = FIELD_GET(INV_ICM42607_PWR_MGMT0_GYRO_MODE_MASK, val); + + if (gyro == oldgyro && accel == oldaccel) + return 0; + + /* + * Datasheet on page 14.26 says we need to ensure the gyro sensor is on + * for a minimum of 45ms. So if we transition from an on state to an + * off state make sure at least 45ms have passed before power off and + * wait if it hasn't. + */ + if (!gyro && oldgyro) { + disable_wait = ktime_us_delta(st->conf.gyro_stop, + ktime_get()); + disable_wait = clamp(disable_wait, 0, + INV_ICM42607_GYRO_STOP_TIME_US); + fsleep(disable_wait); + } + + val = FIELD_PREP(INV_ICM42607_PWR_MGMT0_GYRO_MODE_MASK, gyro); + val |= FIELD_PREP(INV_ICM42607_PWR_MGMT0_ACCEL_MODE_MASK, accel); + ret = regmap_write(st->map, INV_ICM42607_REG_PWR_MGMT0, val); + if (ret) + return ret; + + /* + * If a state change occurs from off to on, sleep for the startup + * time of the sensor, unless a sleep_ms is specified. Since more + * than one sensor can be transitioned from off to on, select the + * maximum time from each of the sensors changing from off to on. + * The startup time for the temp sensor is considerably smaller + * than the startup time for the other sensors and one or more are + * required to be on for the temp sensor to function, so any start + * delay should be enough. + */ + if (accel && !oldaccel) + sleepval_us = max(sleepval_us, INV_ICM42607_ACCEL_STARTUP_TIME_US); + + if (gyro && !oldgyro) { + sleepval_us = max(sleepval_us, INV_ICM42607_GYRO_STARTUP_TIME_US); + /* Track the earliest we can turn off the gyroscope. */ + st->conf.gyro_stop = ktime_add_us(ktime_get(), + INV_ICM42607_GYRO_STOP_TIME_US); + } + + fsleep(sleepval_us); + + return 0; +} + static int inv_icm42607_set_init_conf(struct inv_icm42607_state *st, const struct inv_icm42607_conf *conf) { @@ -214,12 +283,17 @@ static int inv_icm42607_enable_vddio_reg(struct inv_icm42607_state *st) { int ret; + if (st->vddio_en) + return 0; + ret = regulator_enable(st->vddio_supply); if (ret) return ret; fsleep(INV_ICM42607_POWER_UP_TIME_US); + st->vddio_en = true; + return 0; } @@ -227,7 +301,12 @@ static void inv_icm42607_disable_vddio_reg(void *_data) { struct inv_icm42607_state *st = _data; + if (!st->vddio_en) + return; + regulator_disable(st->vddio_supply); + + st->vddio_en = false; } int inv_icm42607_core_probe(struct regmap *regmap, @@ -242,6 +321,8 @@ int inv_icm42607_core_probe(struct regmap *regmap, if (!st) return -ENOMEM; + dev_set_drvdata(dev, st); + ret = devm_mutex_init(dev, &st->lock); if (ret) return ret; @@ -277,10 +358,75 @@ int inv_icm42607_core_probe(struct regmap *regmap, if (ret) return ret; + ret = devm_pm_runtime_set_active_enabled(dev); + if (ret) + return ret; + + pm_runtime_set_autosuspend_delay(dev, INV_ICM42607_SUSPEND_DELAY_MS); + pm_runtime_use_autosuspend(dev); + return 0; } EXPORT_SYMBOL_NS_GPL(inv_icm42607_core_probe, "IIO_ICM42607"); +static int inv_icm42607_suspend(struct device *dev) +{ + struct inv_icm42607_state *st = dev_get_drvdata(dev); + int ret; + + ret = pm_runtime_force_suspend(dev); + if (ret) + return ret; + + inv_icm42607_disable_vddio_reg(st); + + return 0; +} + +static int inv_icm42607_resume(struct device *dev) +{ + struct inv_icm42607_state *st = dev_get_drvdata(dev); + int ret; + + ret = inv_icm42607_enable_vddio_reg(st); + if (ret) + return ret; + + return pm_runtime_force_resume(dev); +} + +static int inv_icm42607_runtime_suspend(struct device *dev) +{ + struct inv_icm42607_state *st = dev_get_drvdata(dev); + + guard(mutex)(&st->lock); + + /* save sensors state */ + st->suspended.gyro = st->conf.gyro.mode; + st->suspended.accel = st->conf.accel.mode; + + return inv_icm42607_set_pwr_mgmt0(st, INV_ICM42607_SENSOR_MODE_OFF, + INV_ICM42607_SENSOR_MODE_OFF); +} + +static int inv_icm42607_runtime_resume(struct device *dev) +{ + struct inv_icm42607_state *st = dev_get_drvdata(dev); + + guard(mutex)(&st->lock); + + /* restore sensors state */ + return inv_icm42607_set_pwr_mgmt0(st, st->suspended.gyro, + st->suspended.accel); +} + +EXPORT_NS_GPL_DEV_PM_OPS(inv_icm42607_pm_ops, IIO_ICM42607) = { + SYSTEM_SLEEP_PM_OPS(inv_icm42607_suspend, inv_icm42607_resume) + RUNTIME_PM_OPS(inv_icm42607_runtime_suspend, + inv_icm42607_runtime_resume, + NULL) +}; + MODULE_AUTHOR("InvenSense, Inc."); MODULE_DESCRIPTION("InvenSense ICM-42607 device driver"); MODULE_LICENSE("GPL"); diff --git a/drivers/iio/imu/inv_icm42607/inv_icm42607_i2c.c b/drivers/iio/imu/inv_icm42607/inv_icm42607_i2c.c index bde931752eb8..aed04be28528 100644 --- a/drivers/iio/imu/inv_icm42607/inv_icm42607_i2c.c +++ b/drivers/iio/imu/inv_icm42607/inv_icm42607_i2c.c @@ -85,6 +85,7 @@ static struct i2c_driver inv_icm42607_driver = { .driver = { .name = "inv-icm42607-i2c", .of_match_table = inv_icm42607_of_matches, + .pm = pm_ptr(&inv_icm42607_pm_ops), }, .id_table = inv_icm42607_id, .probe = inv_icm42607_probe, diff --git a/drivers/iio/imu/inv_icm42607/inv_icm42607_spi.c b/drivers/iio/imu/inv_icm42607/inv_icm42607_spi.c index 6072ed7adc86..137cd34582d8 100644 --- a/drivers/iio/imu/inv_icm42607/inv_icm42607_spi.c +++ b/drivers/iio/imu/inv_icm42607/inv_icm42607_spi.c @@ -95,6 +95,7 @@ static struct spi_driver inv_icm42607_driver = { .driver = { .name = "inv-icm42607-spi", .of_match_table = inv_icm42607_of_matches, + .pm = pm_ptr(&inv_icm42607_pm_ops), }, .id_table = inv_icm42607_spi_id_table, .probe = inv_icm42607_probe, -- 2.43.0