Re: [PATCH V15 8/9] iio: imu: inv_icm42607: Add Temp Support in icm42607

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The IIO temperature channel advertises support for `IIO_CHAN_INFO_SAMP_FREQ` (for read, write, and read_avail), but the `read_avail`, `write_raw`, and `write_raw_get_fmt` callbacks incorrectly reject the `IIO_TEMP` channel.
--

commit 0961338c1e88a743de08d3a1a83292daf58d5ceb
Author: Chris Morgan <macromorgan@hotmail.com>

iio: imu: inv_icm42607: Add Temp Support in icm42607

Add functions for reading temperature sensor data.

> diff --git a/drivers/iio/imu/inv_icm42607/inv_icm42607_accel.c b/drivers/iio/imu/inv_icm42607/inv_icm42607_accel.c
> index 8ef9fdae1bc84..5ff6756b95154 100644
> --- a/drivers/iio/imu/inv_icm42607/inv_icm42607_accel.c
> +++ b/drivers/iio/imu/inv_icm42607/inv_icm42607_accel.c
[ ... ]
> @@ -54,6 +56,7 @@ static const struct iio_chan_spec inv_icm42607_accel_channels[] = {
>  				inv_icm42607_accel_ext_infos),
>  	INV_ICM42607_ACCEL_CHAN(IIO_MOD_Z, INV_ICM42607_ACCEL_SCAN_Z,
>  				inv_icm42607_accel_ext_infos),
> +	INV_ICM42607_TEMP_CHAN(INV_ICM42607_ACCEL_SCAN_TEMP),
>  };

[Severity: Medium]
Since INV_ICM42607_TEMP_CHAN advertises support for IIO_CHAN_INFO_SAMP_FREQ,
will accessing the sampling frequency attributes for the temperature channel
fail?

For example, when reading available frequencies,
inv_icm42607_accel_read_avail() unconditionally rejects non-acceleration
channels:

	if (chan->type != IIO_ACCEL)
		return -EINVAL;

Will the same issue happen for writing SAMP_FREQ in
inv_icm42607_accel_write_raw() and inv_icm42607_accel_write_raw_get_fmt(), as
they also check for IIO_ACCEL only?

> diff --git a/drivers/iio/imu/inv_icm42607/inv_icm42607_gyro.c b/drivers/iio/imu/inv_icm42607/inv_icm42607_gyro.c
> index c7215b3826adc..4e5db5e19e9f3 100644
> --- a/drivers/iio/imu/inv_icm42607/inv_icm42607_gyro.c
> +++ b/drivers/iio/imu/inv_icm42607/inv_icm42607_gyro.c
[ ... ]
> @@ -54,6 +56,7 @@ static const struct iio_chan_spec inv_icm42607_gyro_channels[] = {
>  			       inv_icm42607_gyro_ext_infos),
>  	INV_ICM42607_GYRO_CHAN(IIO_MOD_Z, INV_ICM42607_GYRO_SCAN_Z,
>  			       inv_icm42607_gyro_ext_infos),
> +	INV_ICM42607_TEMP_CHAN(INV_ICM42607_GYRO_SCAN_TEMP),
>  };

[Severity: Medium]
Similar to the acceleration channels above, will the temperature channel fail
when reading or writing SAMP_FREQ here, since inv_icm42607_gyro_read_avail()
and inv_icm42607_gyro_write_raw() unconditionally return -EINVAL if the
channel type is not IIO_ANGL_VEL?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260626161230.93069-1-macroalpha82@gmail.com?part=8