Re: [PATCH v3 1/2] dt-bindings: iio: magnetometer: add Melexis MLX90393

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The required properties `vdd-supply` and `vddio-supply` are omitted from the `properties:` block and missing from the `examples:` node, causing schema validation failures.
--

commit c1fe5f8c39a4b8113c50e154a6674ac296637f70
Author: Nikhil Gautam <nikhilgtr@gmail.com>

dt-bindings: iio: magnetometer: add Melexis MLX90393

Add devicetree bindings for the Melexis MLX90393 3-axis magnetometer and
temperature sensor.

> diff --git a/Documentation/devicetree/bindings/iio/magnetometer/melexis,mlx90393.yaml b/Documentation/devicetree/bindings/iio/magnetometer/melexis,mlx90393.yaml
> new file mode 100644
> index 0000000000000..33ab0be663450
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/magnetometer/melexis,mlx90393.yaml

[ ... ]

> +properties:
> +  compatible:
> +    const: melexis,mlx90393
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  trigger-gpios:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - vdd-supply
> +  - vddio-supply
> +
> +additionalProperties: false

[Severity: Low]
Will this binding fail schema validation when running dt_binding_check?

The vdd-supply and vddio-supply properties are listed as required, but
they are not defined in the properties block.

Because additionalProperties is set to false, wouldn't the schema reject
these supply properties during validation?

> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        magnetometer@c {
> +            compatible = "melexis,mlx90393";
> +            reg = <0x0c>;
> +
> +            interrupt-parent = <&gpio>;
> +            interrupts = <17 IRQ_TYPE_EDGE_RISING>;
> +
> +            trigger-gpios = <&gpio 18 GPIO_ACTIVE_HIGH>;
> +        };
> +    };

[Severity: Low]
Does this example node need to include the vdd-supply and vddio-supply
properties to pass validation, since they are marked as required above?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260627005843.7786-1-nikhilgtr@gmail.com?part=1