Re: [PATCH 2/2] arm64: tegra: Add Lenovo ThinkEdge SE70 carrier board DTS

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The `cd-gpios` property for the external SD card slot specifies `GPIO_ACTIVE_HIGH`, which inverts the typical hardware polarity and will likely break card detection.
--

commit 088caacbb90a6db1efc42acd89fb5cd05dff08d7
Author: Jiqi Li <lijq9@lenovo.com>

arm64: tegra: Add Lenovo ThinkEdge SE70 carrier board DTS

This commit adds a standalone device tree for the Lenovo ThinkEdge SE70
carrier board, which is based on the Tegra194 Xavier NX SOM. It configures
core peripherals including a custom 40-pin header and an external SD card
slot with a dedicated 3.3V regulator. Unpopulated PWM and fan peripherals
are explicitly disabled.

> diff --git a/arch/arm64/boot/dts/nvidia/tegra194-lenovo-thinkedge-se70.dts b/arch/arm64/boot/dts/nvidia/tegra194-lenovo-thinkedge-se70.dts
> new file mode 100644
> index 0000000000000..969ea1783bbde
> --- /dev/null
> +++ b/arch/arm64/boot/dts/nvidia/tegra194-lenovo-thinkedge-se70.dts

[ ... ]

> +		/* SDMMC3 for external user SD card slot with dedicated 3.3V power */
> +		mmc@3440000 {
> +			bus-width = <4>;
> +			cd-gpios = <&gpio_aon TEGRA194_AON_GPIO(CC, 4) GPIO_ACTIVE_HIGH>;

[Severity: High]
Does this active-high polarity for cd-gpios correctly match the hardware?

Standard mechanical SD card slots typically pull this pin to ground (logic LOW)
when a card is inserted, meaning GPIO_ACTIVE_LOW is usually required.

If there isn't a discrete hardware inverter on the SE70 carrier board, will
this configuration invert the card detection logic and report the slot as empty
when a card is actually inserted?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260628124318.627393-1-lijq9@lenovo.com?part=2