Re: [PATCH v1 2/4] arm64: dts: ti: var-som-am62p: update audio codec configuration

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incomplete device tree audio routing configuration for the new DMIC on IN1L.
--

commit 7dd222d83843c4dcd6d8e965ee097f2c019186e6
Author: Stefano Radaelli <stefano.r@variscite.com>

arm64: dts: ti: var-som-am62p: update audio codec configuration

Update the WM8904 audio codec configuration on the VAR-SOM-AM62P.
Set the audio reference clock rate to 12 MHz and add the codec DRC, GPIO
and DMIC configuration required by the board.

> diff --git a/arch/arm64/boot/dts/ti/k3-am62p5-var-som.dtsi b/arch/arm64/boot/dts/ti/k3-am62p5-var-som.dtsi
> index be19cbaffc4b0..9440891339b3a 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62p5-var-som.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62p5-var-som.dtsi

[ ... ]

> @@ -204,6 +204,25 @@ wm8904: audio-codec@1a {
>  		DBVDD-supply = <&reg_3v3>;
>  		DCVDD-supply = <&reg_1v8>;
>  		MICVDD-supply = <&reg_1v8>;
> +		wlf,drc-cfg-names = "default", "peaklimiter", "tradition",
> +				    "soft", "music";
> +		/*
> +		 * Config registers per name, respectively:
> +		 * KNEE_IP = 0,   KNEE_OP = 0,     HI_COMP = 1,   LO_COMP = 1
> +		 * KNEE_IP = -24, KNEE_OP = -6,    HI_COMP = 1/4, LO_COMP = 1
> +		 * KNEE_IP = -42, KNEE_OP = -3,    HI_COMP = 0,   LO_COMP = 1
> +		 * KNEE_IP = -45, KNEE_OP = -9,    HI_COMP = 1/8, LO_COMP = 1
> +		 * KNEE_IP = -30, KNEE_OP = -10.5, HI_COMP = 1/4, LO_COMP = 1
> +		 */
> +		wlf,drc-cfg-regs = /bits/ 16 <0x01af 0x3248 0x0000 0x0000>,
> +				   /bits/ 16 <0x04af 0x324b 0x0010 0x0408>,
> +				   /bits/ 16 <0x04af 0x324b 0x0028 0x0704>,
> +				   /bits/ 16 <0x04af 0x324b 0x0018 0x078c>,
> +				   /bits/ 16 <0x04af 0x324b 0x0010 0x050e>;
> +		/* GPIO1 = DMIC_CLK, don't touch others */
> +		wlf,gpio-cfg = <0x0018>, <0xffff>, <0xffff>, <0xffff>;
> +		/* DMIC is connected to IN1L */
> +		wlf,in1l-as-dmicdat1;

[Severity: Medium]
Does this new DMIC configuration conflict with the existing simple-audio-card
routing?

Earlier in the file, the ALSA DAPM audio routing maps IN1L to an external
analog microphone jack:

	sound {
		...
		simple-audio-card,routing =
			...
			"IN1L", "Microphone Jack",
			"IN1R", "Microphone Jack";

Since IN1L is now configured as a digital microphone (DMIC), should the routing
be updated so ALSA DAPM doesn't incorrectly couple the DMIC's power sequencing
and userspace representation with a physical analog jack widget?

>  	};
>  };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1782665899.git.stefano.r@variscite.com?part=2