Re: [PATCH RFC v6 1/5] dt-bindings: iio: add Open Sensor Fusion device

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Using a generic protocol name as the sole compatible string instead of a specific product identity.
--

commit 52d695764bb9f94bbb11a6128ea968762ee2ceef
Author: Jinseob Kim <kimjinseob88@gmail.com>

dt-bindings: iio: add Open Sensor Fusion device

This commit adds a binding for the generic Open Sensor Fusion host interface.
Sensor channels and protocol versions are discovered dynamically at runtime,
so they are not described individually in the Device Tree.

> diff --git a/Documentation/devicetree/bindings/iio/opensensorfusion,osf.yaml b/Documentation/devicetree/bindings/iio/opensensorfusion,osf.yaml
> new file mode 100644
> index 0000000000000..8016d582fd970
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/opensensorfusion,osf.yaml
[ ... ]
> +properties:
> +  compatible:
> +    const: opensensorfusion,osf

[Severity: Medium]
Does this generic compatible string prevent the kernel from applying future
quirks or workarounds if a specific board revision or hardware variant has
silicon bugs or unique power sequencing requirements?

The commit message mentions that product identities are explicitly not used
as the compatible string. By defining the generic protocol name as the only
valid value, the kernel lacks the ability to distinguish between different
hardware implementations that might need specific handling.

Would it be more appropriate to allow or require a hardware-specific
compatible string (such as the OSF Green product identity) alongside the
generic fallback?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260628191337.937-1-kimjinseob88@gmail.com?part=1