Re: [PATCH v3 1/2] dt-bindings: power: supply: Add TI BQ25630 charger

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The devicetree binding example references an undefined phandle label `&bat`, which will cause `dtc` compilation to fail during `make dt_binding_check`.
--

commit 4d0f17bc3ce487f6e8027b9ef945b17aba3d6bee
Author: Waqar Hameed <waqar.hameed@axis.com>

dt-bindings: power: supply: Add TI BQ25630 charger

This commit adds devicetree bindings for the TI BQ25630 battery charger.
It defines standard properties for I2C and interrupts, and sets up
requirements for a monitored battery reference.

> diff --git a/Documentation/devicetree/bindings/power/supply/ti,bq25630.yaml b/Documentation/devicetree/bindings/power/supply/ti,bq25630.yaml
> new file mode 100644
> index 0000000000000..3f2904731c5a4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/ti,bq25630.yaml

[ ... ]

> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        charger@6b {
> +            compatible = "ti,bq25630";
> +            reg = <0x6b>;
> +            interrupts = <13 IRQ_TYPE_EDGE_FALLING>;
> +            monitored-battery = <&bat>;

[Severity: Low]
Does this example reference an undefined phandle label?

Looking at the example scope, the node with the bat label is not defined
anywhere. Could this cause dtc compilation to fail with a 'Reference to 
non-existent node or label' error during make dt_binding_check?

> +        };
> +    };
> +...

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1782683551.git.waqar.hameed@axis.com?part=1