From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout02.posteo.de (mout02.posteo.de [185.67.36.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C5AF4508E0 for ; Mon, 29 Jun 2026 16:52:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.67.36.66 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782751937; cv=none; b=BRv03lDmfJ5UTaHBnRcJ1Iys8MlKsvN/UtciNOn49G1bDFoXCberqOuoMIrR3NHeJXsYMhCGLV/04E0rUkUo9jnHTUJ5fOu2CiaBqYzbsXIm97uIBpHm7zQ34J27eXx8WHFNIP8ylQXpgMG/UvF63m2BRdml33XHzk3QA5QD658= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782751937; c=relaxed/simple; bh=z1zZh1djxGy2ZsNvysNjNmKprImL5Jf2OqcaRQQylGE=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=bLTa9NC/7ZydDB6kQo2NQpOj98pus22Mb7cwWcjEqF8ik7ga3CWwWrTSACmKmAzP330Rh/LsAScRQlGEEl0Ew9gcJQ6aLhRC/icGp06PNH/A3zqr+cWIwoIvPejidKPJZ6LpuedUYhXyhFuXnwr4X0ILLK0V3bXlMzRXjaslv+E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.de; spf=pass smtp.mailfrom=posteo.de; dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de header.b=P+ILBzph; arc=none smtp.client-ip=185.67.36.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=posteo.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de header.b="P+ILBzph" Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 76A98240101 for ; Mon, 29 Jun 2026 18:52:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=posteo.de; s=2017; t=1782751932; bh=xnap5pPEwOijocoUIJe48x7ZycTeTyEXbYr2mwb6y28=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:To:Cc:Autocrypt:OpenPGP:From; b=P+ILBzph0y9GygviVS/IC8i450OiaqO3uM0TyIH1R0JrKceAqJXkFLnaAYbnv5b6l AT9bg1qMel0k6qIToA9lliDabofpxDgdiINqSstesnt4AbOpGKQAUwKUCatFkke7jX hXIzg2iKzxHl+PfUoxv1qCZ52MCDHJtA9MQOxZB9CHUSlmxoOTT+eFfQ2EaRp+ktpi ZHgoMRWZzXpus8M1y/gzM2PwmrkS6S/2lVTNLjKcuuTFaGe2JzzheX6E/J4yiobdGf Vueyg6xxi1MoVGqUd0g+9P4rkRFP+oA1jOsdg+481IqWsE+9onRi2K/4OH72+UD3m2 Fyk2K78RJlTvQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4gpskw1d6Pz6twQ; Mon, 29 Jun 2026 18:52:07 +0200 (CEST) From: Markus Probst Subject: [PATCH v16 0/2] Introduce Synology Microp driver Date: Mon, 29 Jun 2026 16:52:11 +0000 Message-Id: <20260629-synology_microp_initial-v16-0-601e91c49e0d@posteo.de> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAAAAAAAC/4XU247aMBAG4FdBua6Rxx6fuNr3qCrkw5iNFgibs FHRinevEy5qkZJe2tJ89oz/5LsZqG9paHab76ansR3a7lwWoH9smvjuzwdibSobjeBCc8k1G27 n7tgdbvtTG/vusm/P7bX1R8azST6aYNDpplRfesrt75n++eux7unzq5xwfWw2JxoGPx+w28y8k hykMFJvpXBWoWPAkv/o3z6oP9Nx2/WHpr7XXKZAgGH913Ddl14SjYxIoQVy3Kq4G0H8qwYAHzV HSgPzTrlsosgmu90oYKoIfiAWu9Opve42o9kK1kdopk7e2+Ha9bd5ZiPMrfx3OiMwznLMmRJpR BvfLt1wpW6baDZHUTv2tSOK46R1TsssIapnR1YOyNeOLI5P2kfU0gsOzw5WjuCvHSwORyFTClZ Gj8+Oqh332lHFESYGy0PKyi3uo/86yNVrR0/3sTkRGgw6umfHVA7Aa8dMc/bSc4dkyoieHVs5a /OxxTEOtXcgEJd9udpZeS9XHPRWSZmtIW6eHeA1hCtBLPNhZJVIIksKfnEjgFoyK9KUaRchJOV 1sdJCErW08vgwpRq554pLGbXgC6mKdflLrEhzrr0IwUWlKS++M8BaWgkATMkGaUxCoYLAsJCqa OvV7qZsY5Cp/NlMNDHX0v1+/wNLzuHFhQUAAA== X-Change-ID: 20260306-synology_microp_initial-0f7dac7b7496 To: Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Bryan O'Donoghue , Lee Jones , Pavel Machek , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Daniel Almeida , Tamir Duberstein , Alexandre Courbot , =?utf-8?q?Onur_=C3=96zkan?= Cc: platform-driver-x86@vger.kernel.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Markus Probst , Krzysztof Kozlowski X-Developer-Signature: v=1; a=openpgp-sha256; l=7570; i=markus.probst@posteo.de; h=from:subject:message-id; bh=z1zZh1djxGy2ZsNvysNjNmKprImL5Jf2OqcaRQQylGE=; b=owEBiQJ2/ZANAwAIATR2H/jnrUPSAcsmYgBqQqK3IFG5xwzh4fCYyU5FzLqA1f3n60NHOJI6k M67Oa6drM+JAk8EAAEIADkWIQSCdBjE9KxY53IwxHM0dh/4561D0gUCakKitxsUgAAAAAAEAA5t YW51MiwyLjUrMS4xMiwyLDIACgkQNHYf+OetQ9JNXBAAgB/DvbWW1L2gH04dS+mtuxmhUwV+/Ut dGBTgMiocD1+TkKxSoQZuKXOlMGrwIQr7Yq1CBizS5Oq7ItUCT/B8V6JZVXk3f5TeEsqegJnssB JZiWHgygWwkU9K3aeckPd+FdnFH69PQbIyK64fvk5xdYGY9EJqmmffgrzprOhnx4YNuQ4votPPu tOH318iAcP66OK6SgLag/xF7rPC8rOVpO6uQdF3q/HfqM+nS2bycX5RvdI7RWMzbtoakqIwuTDY Z1ykuX30S/6gL3k29f3oLquDVb5fy5sbl4Erbmd+9cTn7IMZ6SP1fVRZrs/jYXi9+M1+hC3+apd JAtNA8BLOEssgDR82HYbKORtv9oVXkYe5FRTBnpfoyC9W/gYV37vMud3VP2GDkSsjU8XbFRgyPi 46MwT5iUXa5iJyUDboE2NzSXuV73x81nsdcUxMiOCxTMjk4fnKW7sDHBjR3s0OB5haK7hRmyYad W8UZmAEDiJjbKHD2NB0/CJ6rUNi0g1TKa3WlX0RU66U5/7o9TydCvlvt5+mZd3uc4JIy89vQzZk aGo8P/wndiDCvhEmXwfgvMXAa8zpyMYE//JMaT1oERaf9Le79Rn98tJglSOyD4RGxa1CCQ1NS7z Uw0ByY/ZC9lSHI5F/5CPHTeMUHZRGl4XOCpG8s00zu6DYCjw6hf0= X-Developer-Key: i=markus.probst@posteo.de; a=openpgp; fpr=827418C4F4AC58E77230C47334761FF8E7AD43D2 Autocrypt: addr=markus.probst@posteo.de; prefer-encrypt=mutual; keydata=xsFNBGiDvXgBEADAXUceKafpl46S35UmDh2wRvvx+UfZbcTjeQOlSwKP7YVJ4JOZrVs93qReNLkO WguIqPBxR9blQ4nyYrqSCV+MMw/3ifyXIm6Pw2YRUDg+WTEOjTixRCoWDgUj1nOsvJ9tVAm76Ww+ /pAnepVRafMID0rqEfD9oGv1YrfpeFJhyE2zUw3SyyNLIKWD6QeLRhKQRbSnsXhGLFBXCqt9k5JA RhgQof9zvztcCVlT5KVvuyfC4H+HzeGmu9201BVyihJwKdcKPq+n/aY5FUVxNTgtI9f8wIbmfAja oT1pjXSp+dszakA98fhONM98pOq723o/1ZGMZukyXFfsDGtA3BB79HoopHKujLGWAGskzClwTjRQ xBqxh/U/lL1pc+0xPWikTNCmtziCOvv0KA0arDOMQlyFvImzX6oGVgE4ksKQYbMZ3Ikw6L1Rv1J+ FvN0aNwOKgL2ztBRYscUGcQvA0Zo1fGCAn/BLEJvQYShWKeKqjyncVGoXFsz2AcuFKe1pwETSsN6 OZncjy32e4ktgs07cWBfx0v62b8md36jau+B6RVnnodaA8++oXl3FRwiEW8XfXWIjy4umIv93tb8 8ekYsfOfWkTSewZYXGoqe4RtK80ulMHb/dh2FZQIFyRdN4HOmB4FYO5sEYFr9YjHLmDkrUgNodJC XCeMe4BO4iaxUQARAQABzRdtYXJrdXMucHJvYnN0QHBvc3Rlby5kZcLBkQQTAQgAOxYhBIJ0GMT0 rFjncjDEczR2H/jnrUPSBQJog714AhsDBQsJCAcCAiICBhUKCQgLAgQWAgMBAh4HAheAAAoJEDR2 H/jnrUPSgdkQAISaTk2D345ehXEkn5z2yUEjaVjHIE7ziqRaOgn/QanCgeTUinIv6L6QXUFvvIfH 1OLPwQ1hfvEg9NnNLyFezWSy6jvoVBTIPqicD/r3FkithnQ1IDkdSjrarPMxJkvuh3l7XZHo49GV HQ8i5zh5w4YISrcEtE99lJisvni2Jqx7we5tey9voQFDyM8jxlSWv3pmoUTCtBkX/eKHJXosgsuS B4TGDCVPOjla/emI5c9MhMG7O4WEEmoSdPbmraPw66YZD6uLyhV4DPHbiDWRzXWnClHSyjB9rky9 lausFxogvu4l9H+KDsXIadNDWdLdu1/enS/wDd9zh5S78rY2jeXaG4mnf4seEKamZ7KQ6FIHrcyP ezdDzssPQcTQcGRMQzCn6wP3tlGk7rsfmyHMlFqdRoNNv+ZER/OkmZFPW655zRfbMi0vtrqK2Awm 9ggobb1oktfd9PPNXMUY+DNVlgR2G7jLnenSoQausLUm0pHoNE8TWFv851Y6SOYnvn488sP1Tki5 F3rKwclawQFHUXTCQw+QSh9ay8xgnNZfH+u9NY7w3gPoeKBOAFcBc2BtzcgekeWS8qgEmm2/oNFV G0ivPQbRx8FjRKbuF7g3YhgNZZ0ac8FneuUtJ2PkSIFTZhaAiC0utvxk0ndmWFiW4acEkMZGrLaM L2zWNjrqwsD2zsFNBGiDvXgBEADCXQy1n7wjRxG12DOVADawjghKcG+5LtEf31WftHKLFbp/HArj BhkT6mj+CCI1ClqY+FYU5CK/s0ScMfLxRGLZ0Ktzawb78vOgBVFT3yB1yWBTewsAXdqNqRooaUNo 8cG/NNJLjhccH/7PO/FWX5qftOVUJ/AIsAhKQJ18Tc8Ik73v427EDxuKb9mTAnYQFA3Ev3hAiVbO 6Rv39amVOfJ8sqwiSUGidj2Fctg2aB5JbeMln0KCUbTD1LhEFepeKypfofAXQbGwaCjAhmkWy/q3 IT1mUrPxOngbxdRoOx1tGUC0HCMUW1sFaJgQPMmDcR0JGPOpgsKnitsSnN7ShcCr1buel7vLnUMD +TAZ5opdoF6HjAvAnBQaijtK6minkrM0seNXnCg0KkV8xhMNa6zCs1rq4GgjNLJue2EmuyHooHA4 7JMoLVHcxVeuNTp6K2+XRx0Pk4e2Lj8IVy9yEYyrywEOC5XRW37KJjsiOAsumi1rkvM7QREWgUDe Xs0+RpxI3QrrANh71fLMRo7LKRF3Gvw13NVCCC9ea20P4PwhgWKStkwO2NO+YJsAoS1QycMi/vKu 0EHhknYXamaSV50oZzHKmX56vEeJHTcngrM8R1SwJCYopCx9gkz90bTVYlitJa5hloWTYeMD7FNj Y6jfVSzgM/K4gMgUNDW/PPGeMwARAQABwsF2BBgBCAAgFiEEgnQYxPSsWOdyMMRzNHYf+OetQ9IF AmiDvXgCGwwACgkQNHYf+OetQ9LHDBAAhk+ab8+WrbS/b1/gYW3q1KDiXU719nCtfkUVXKidW5Ec Idlr5HGt8ilLoxSWT2Zi368iHCXS0WenGgPwlv8ifvB7TOZiiTDZROZkXjEBmU4nYjJ7GymawpWv oQwjMsPuq6ysbzWtOZ7eILx7cI0FjQeJ/Q2baRJub0uAZNwBOxCkAS6lpk5Fntd2u8CWmDQo4SYp xeuQ+pwkp0yEP30RhN2BO2DXiBEGSZSYh+ioGbCHQPIV3iVj0h6lcCPOqopZqyeCfigeacBI0nvN jHWz/spzF3+4OS+3RJvoHtAQmProxyGib8iVsTxgZO3UUi4TSODeEt0i0kHSPY4sCciOyXfAyYoD DFqhRjOEwBBxhr+scU4C1T2AflozvDwq3VSONjrKJUkhd8+WsdXxMdPFgBQuiKKwUy11mz6KQfcR wmDehF3UaUoxa+YIhWPbKmycxuX/D8SvnqavzAeAL1OcRbEI/HsoroVlEFbBRNBZLJUlnTPs8ZcU 4+8rq5YX1GUrJL3jf6SAfSgO7UdkEET3PdcKFYtS+ruV1Cp5V0q4kCfI5jk25iiz8grM2wOzVSsc l1mEkhiEPH87HP0whhb544iioSnumd3HJKL7dzhRegsMizatupp8D65A2JziW0WKopa1iw9fti3A aBeNN4ijKZchBXHPgVx+YtWRHfcm4l8= OpenPGP: url=https://posteo.de/keys/markus.probst@posteo.de.asc; preference=encrypt Synology uses a microcontroller in their NAS devices connected to a serial port to control certain LEDs, fan speeds, a beeper, to handle proper shutdown and restart, buttons and fan failures. This patch series depends on the rust led abstraction [1] and the rust serdev abstraction [2]. This is only a initial version of the driver able to control LEDs. The following rust abstractions would be required, to implement the remaining features: - hwmon (include/linux/hwmon.h) - input (include/linux/input.h) - sysoff handler (include/linux/reboot.h) [1] https://lore.kernel.org/rust-for-linux/20260629-rust_leds-v21-0-4f0f19579db5@posteo.de/ [2] https://lore.kernel.org/rust-for-linux/20260603-rust_serdev-v12-0-3400ffb88b12@posteo.de/ Signed-off-by: Markus Probst --- Changes in v16: - fix issues reported by Sashiko: - fix typo in dt compatible - fix not compilable as loadable module - Link to v15: https://patch.msgid.link/20260629-synology_microp_initial-v15-0-4b3d7367c7cf@posteo.de Changes in v15: - adapted to rust led abstractiopn v21 - Link to v14: https://patch.msgid.link/20260531-synology_microp_initial-v14-0-1377d425b24b@posteo.de Changes in v14: - adapt to led abstraction v18 and serdev abstraction v11 - Link to v13: https://patch.msgid.link/20260530-synology_microp_initial-v13-0-aa2bb9c56efc@posteo.de Changes in v13: - adapted to driver-lifetime v5 patch series. - set blink = false as initial power led state, as set_blink hasn't been called yet (even though the led is blinking at startup) - Link to v12: https://patch.msgid.link/20260429-synology_microp_initial-v12-0-40a05033c620@posteo.de Changes in v12: - adapted to driver-lifetime patch series. The driver can't take advantage of it, until class devices like led also make use of it. - Link to v11: https://patch.msgid.link/20260427-synology_microp_initial-v11-0-9c1bd5a6f3ed@posteo.de Changes in v11: - rebased on top of 7.1-rc1 - add "synology" as devicename to led, like it is done in existing dts files in the kernel - fix color for led being orange instead of amber. I personally can't clearly tell them apart, but apparently its amber. - replaced MCU with EC in Kconfig help - Link to v10: https://patch.msgid.link/20260424-synology_microp_initial-v10-0-e852d2f3eba1@posteo.de Changes in v10: - resolved issues reported by Sashiko Bot: - removed unneeded include from device tree - fix typo in of device table - fix blink not set to false, if delay_off or delay_on is 0 - Link to v9: https://patch.msgid.link/20260423-synology_microp_initial-v9-0-4a8533f87e07@posteo.de Changes in v9: - separate fallback and front compatibles in dt schema - remove front compatibles from of id table, if all functionality is by covered by the fallback - remove TODO file - add platform-driver-x86@vger.kernel.org to Maintainers file entry - use `Delta` type in `BLINK_DELAY` const - Link to v8: https://patch.msgid.link/20260420-synology_microp_initial-v8-0-7946a9124491@posteo.de Changes in v8: - removed unnecessary Copy and Clone derive - added `BLINK_DELAY` constant - added compatible id fallbacks - moved dt schema patch before the driver - added ds411p - Link to v7: https://lore.kernel.org/r/20260411-synology_microp_initial-v7-0-9a3a094e763a@posteo.de Changes in v7: - remove list of compatible ids from commit msg - explain what makes the different models not compatible in the commit msg - remove unnecessary examples - Link to v6: https://lore.kernel.org/r/20260405-synology_microp_initial-v6-0-08fde474b6c9@posteo.de Changes in v6: - moved devicetree bindings patch at the end of the set - remove several patches - move of id table from model.rs to synology_microp.rs - remove the model! macro - use if blocks in devicetree schema to narrow down the fan-failure-gpios property - add multiple devicetree examples to test if blocks - Link to v5: https://lore.kernel.org/r/20260329-synology_microp_initial-v5-0-27cb80bdf591@posteo.de Changes in v5: - add esata led support - use different compatible for each model - add visibility modifier to of_device_table macro - fix match data missing when using PRP0001 - Link to v4: https://lore.kernel.org/r/20260320-synology_microp_initial-v4-0-0423ddb83ca4@posteo.de Changes in v4: - convert to monolithic driver and moved it into drivers/platform - removed mfd rust abstraction - moved dt-bindings to embedded-controller - Link to v3: https://lore.kernel.org/r/20260313-synology_microp_initial-v3-0-ad6ac463a201@posteo.de Changes in v3: - remove `default n` from Kconfig entry, as n is the default already. - select RUST_SERIAL_DEV_BUS_ABSTRACTIONS in Kconfig - add mfd rust abstraction - split core and led parts into their own driver. It should now be considered a MFD device. - split led part of dt binding into its own file - Link to v2: https://lore.kernel.org/r/20260308-synology_microp_initial-v2-0-9389963f31c5@posteo.de Changes in v2: - fix missing tabs in MAINTAINERS file - remove word binding from patch subject - add missing signed-off-by - add missing help entry in Kconfig - add missing spdx license headers - remove no-check{,-cpu}-fan properties from the dt-bindings and replace them with the check_fan module parameter - use patternProperties for leds in dt-bindings - license dt-binding as GPL-2.0-only OR BSD-2-Clause - move driver from staging tree into mfd tree and mark it as work in progress inside Kconfig - only register alert and usb led if fwnode is present - Link to v1: https://lore.kernel.org/r/20260306-synology_microp_initial-v1-0-fcffede6448c@posteo.de --- Markus Probst (2): dt-bindings: embedded-controller: Add synology microp devices platform: Add initial synology microp driver .../synology,ds918p-microp.yaml | 100 +++++++ MAINTAINERS | 7 + drivers/platform/Kconfig | 2 + drivers/platform/Makefile | 1 + drivers/platform/synology_microp/Kconfig | 13 + drivers/platform/synology_microp/Makefile | 5 + drivers/platform/synology_microp/command.rs | 54 ++++ drivers/platform/synology_microp/led.rs | 297 +++++++++++++++++++++ drivers/platform/synology_microp/model.rs | 49 ++++ .../platform/synology_microp/synology_microp.rs | 91 +++++++ 10 files changed, 619 insertions(+) --- base-commit: 728e68a889bcf257b1e67298b12c360e5c3a13e0 change-id: 20260306-synology_microp_initial-0f7dac7b7496 prerequisite-message-id: 20260530132736.3298549-1-dakr@kernel.org prerequisite-patch-id: 310c6bee038ca3909a8e5e58ec12b74f7189b869 prerequisite-patch-id: 92812c3d42b29504838e6dc66c307ff5c035bb5e prerequisite-change-id: 20251217-rust_serdev-ee5481e9085c:v12 prerequisite-patch-id: 059e43aa20628647ba98a0e5582444a5a7b68ec4 prerequisite-patch-id: 310c6bee038ca3909a8e5e58ec12b74f7189b869 prerequisite-patch-id: 92812c3d42b29504838e6dc66c307ff5c035bb5e prerequisite-patch-id: a75cb3f900db0e765351b773cbfffaeb9a01a107 prerequisite-patch-id: 19eb53ce0c653c1406f8f192f6ad158fb4bd8d8f prerequisite-patch-id: 55d6a70baf3be7f4da36b82cf02a5a7d59457520 prerequisite-change-id: 20251114-rust_leds-a959f7c2f7f9:v21 prerequisite-patch-id: d6a2bb314f215e3c6bd3a3ac87b991a33e3d6256 prerequisite-patch-id: 50bfe4b15f07d3733d4fc4b4520ce74cbac2cf4f prerequisite-patch-id: ec48c2616ea8f0bd8f71cec858f1d5d0fdb2bac0