From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 432103783CC for ; Mon, 29 Jun 2026 09:42:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782726177; cv=none; b=jhmbyozK/10qh+EwHTormnKBFu44/sgX/WrW1KcDzm/FAcrAo53deDvl/pOUX8luUz3TcyrmvSQDNCWR8H1otQQhv/78Fbvz9OF7MUqhsaVf/8oMNpSfgjqcLDHGwVH1WimrlroCJrL36fM0RmoX7uju03HJkWTY1A3GyNwQbDs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782726177; c=relaxed/simple; bh=YLwUN3fCCeJRadl1pBVF6TXgm8FtV80yb9GgyLTkP6Q=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=aBI90Lk/kNmCm3TvSfR5bJHxzr6r1Uizc9ngXd/TKUpSpDGeFtdbCvYlllEZCpj+80trz/v54tmkRUYl8bIzeca7X+NThZyTNOBJhll+0lpjycgNt9GvtCA2uerOuLXIvja2AVdJNLynjxCrjPOYLqmkPqJgk+x5IZqhKTTCpX8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=P/5OnZnr; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="P/5OnZnr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AB7281F000E9; Mon, 29 Jun 2026 09:42:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782726175; bh=mBL1BF6BT/SWDEsEKWduChFBHkkQwms1iuOyJGiwgXY=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=P/5OnZnrCEmy84HzuvKEQRDFRVeRGRUqg4IXc2KfeB4qYeUIAaljRYVlp2QE0/E7R N3vq75ifVKXgl4cMj0pX6qub5a0dPXHoLeTIESpLUk7VNeMHgeJGqBwxxMLcrRsIv1 zRWhC34P/ARH49KBb9WzD49z58Sy9f0NsfOB65Yn2Gpv8Hlq0Fe5zlT5qkoHOh2qZE EexSUldlnm3dB5gxPquJ3WwVKL5S05smuSRahQNyEXKptPd9IResept1CwW4a9FhRG FqoABGRdnvC5VAViLNpfBDhrOdarnLlXv2uCYK+uopcH+7BlRnSdLD07Xg0Og63+s7 ZIT8t7yhsrt9Q== From: sashiko-bot@kernel.org Subject: Re: [PATCH v3 1/4] iio: dac: ad3530r: Refactor setup to table-driven register bank approach Reply-To: sashiko-reviews@lists.linux.dev To: "Kim Seer Paller" Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org In-Reply-To: <20260629-iio-ad3532r-support-v3-1-f6e4f4abebbe@analog.com> References: <20260629-iio-ad3532r-support-v3-0-f6e4f4abebbe@analog.com> <20260629-iio-ad3532r-support-v3-1-f6e4f4abebbe@analog.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 29 Jun 2026 09:42:55 +0000 Message-Id: <20260629094255.AB7281F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] The commit message claims to switch `spi_device_id` to named ini= tializers, but this change is missing from the patch. -- commit 54fc2d1026683255f5c87f5095c8f2ddef61fbf3 Author: Kim Seer Paller iio: dac: ad3530r: Refactor setup to table-driven register bank approach This commit replaces direct register calls in ad3530r_setup() with per-chip register address arrays and bank helpers. It also converts sw_ldac_trig_reg to a function pointer for per-bank LDAC trigger register selection. > Replace direct register calls in ad3530r_setup() with per-chip register > address arrays and bank helpers (ad3530r_set_reg_bank_bits, > ad3530r_write_reg_banks). Convert sw_ldac_trig_reg from a static > register address to a function pointer for per-bank LDAC trigger > register selection. Switch spi_device_id to named initializers. [Severity: Medium] Is this description accurate? The commit message claims to switch spi_device_id to named initializers, but this change is missing from the patch. Looking at ad3530r_id in drivers/iio/dac/ad3530r.c, it still uses positional initializers: static const struct spi_device_id ad3530r_id[] =3D { { "ad3530", (kernel_ulong_t)&ad3530_chip }, { "ad3530r", (kernel_ulong_t)&ad3530r_chip }, { "ad3531", (kernel_ulong_t)&ad3531_chip }, { "ad3531r", (kernel_ulong_t)&ad3531r_chip }, { } }; Was this change accidentally omitted from the patch, or should the commit message be updated? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260629-iio-ad3532= r-support-v3-0-f6e4f4abebbe@analog.com?part=3D1