From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C2B6423160 for ; Mon, 29 Jun 2026 12:25:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782735929; cv=none; b=DSr1vlQhdAUm0lLP2ZS2dCMI1yG/DF8knfTx2xSFRcSuxleLKoh+0EIULZwFT0IpB07VbyJNARUCAmb34CuD+Mh/OUN2MNHuYj0zfifEj5FqL9OcjcDW2DHVDij3bAcZ8hurYYgSCbTSoThf/NIMO0+qcJgrkAdEtLOWQbSuQag= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782735929; c=relaxed/simple; bh=x8MM4Vij8UVS2L4dzWDPxWnrGL8KF64f5uSnO3c8IZc=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=iof1l7obNiTAD15keNWHIN+GXD2wXLNqsQSO0WUh2IZ7oPHBURaPERDMWUoBza8QxFD9/0IrDBm/XJN1Qnorntt9co8/bsfnDiL7vsUDrWUws2vF2+aR+4JV7kMdbwkr36X68DleoAkfwFc+SFI8HPWBlIrQhpSi4nHso/Dife8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Gb1zRgy8; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Gb1zRgy8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4CE3D1F000E9; Mon, 29 Jun 2026 12:25:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782735925; bh=oZq3HzBoE6H84O/7Xc4mXuUkH5xcueVnN1SS21e9Nig=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=Gb1zRgy8E001F1aGXXpwrwF9OnyOHrazAH+DSp1V2pUzQyTV2Lx7aU14l/5a1k72P CzVQKp3mZQ8aG4okyTYwgpI3q/RiUBBkk4N2memcivjvWKTh+SYesSzv6j+rDg9OoA 7wb7xzoDt+dDdhPKu68jbhSno3mZqwTJ+IpZHBWAQhNiQGyr0OxSEqjIORpjKjmG74 LXNtHLgCrGd3NgeFifkvVT3/c6N5Mdiq232W66DTprBwVHLpG+lmQQ6TPURTz72/QJ w0oYaJiCAUUiOirBz1dbWvxGhowb5HeQ1LOW92tZqlRWE53J1VpZN/iL4qpH+UPFKJ BsmoCPNRvbKMQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v3 2/4] dt-bindings: media: qcom: Add JPEG encoder binding Reply-To: sashiko-reviews@lists.linux.dev To: "Atanas Filipov" Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org In-Reply-To: <20260629121750.3469292-3-atanas.filipov@oss.qualcomm.com> References: <20260629121750.3469292-1-atanas.filipov@oss.qualcomm.com> <20260629121750.3469292-3-atanas.filipov@oss.qualcomm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 29 Jun 2026 12:25:23 +0000 Message-Id: <20260629122525.4CE3D1F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] Device tree schema validation failure: the example uses an incom= plete and schema-violating parent `camss` node. -- commit 862ed8809d046c435b4cc946e8aea64e3ff8a893 Author: Atanas Filipov dt-bindings: media: qcom: Add JPEG encoder binding This commit adds the device tree binding for the Qualcomm JPEG encoder hardware block found on SM8250 SoCs. It defines the required properties, clocks, and interconnects for the memory-to-memory standalone IP. > diff --git a/Documentation/devicetree/bindings/media/qcom,jpeg-encoder.ya= ml b/Documentation/devicetree/bindings/media/qcom,jpeg-encoder.yaml > new file mode 100644 > index 0000000000000..c8b4808054cb1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/qcom,jpeg-encoder.yaml [ ... ] > +examples: > + - | [ ... ] > + soc { > + #address-cells =3D <2>; > + #size-cells =3D <2>; > + > + camss@ac6a000 { > + compatible =3D "qcom,sm8250-camss"; > + reg =3D <0 0x0ac6a000 0 0x2000>; > + #address-cells =3D <2>; > + #size-cells =3D <2>; > + ranges; > + > + jpeg-encoder@ac53000 { [Severity: Medium] Will this example cause a schema validation failure during make dt_binding_= check? The parent node uses the "qcom,sm8250-camss" compatible string, which means it will be validated against the existing camss schema. Since the camss schema enforces additionalProperties: false and does not permit #address-cells, #size-cells, ranges, or child nodes, the validation will fa= il. The example node also appears to be missing other required properties for t= he camss binding, such as clocks and interrupts. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260629121750.3469= 292-1-atanas.filipov@oss.qualcomm.com?part=3D2