Re: [PATCH v5] dt-bindings: pwm: st,sti-pwm: convert to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `clock-names` YAML schema strictly enforces an ordered list starting with `"pwm"`, which improperly rejects valid capture-only configurations.
--

commit c9b4fd6ce8e4e0ebe419750b4c65554ab14080bc
Author: Charan Pedumuru <charan.pedumuru@gmail.com>

dt-bindings: pwm: st,sti-pwm: convert to DT schema

This commit converts the STMicroelectronics STiH41x PWM/Capture controller
binding from a text file to DT schema. It updates the compatible string to
match hardware conventions and drops inherited pinctrl properties from the
required list.

> diff --git a/Documentation/devicetree/bindings/pwm/st,sti-pwm.yaml b/Documentation/devicetree/bindings/pwm/st,sti-pwm.yaml
> new file mode 100644
> index 0000000000000..39f96596c1ef8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/st,sti-pwm.yaml

[ ... ]

> +  pinctrl-names:
> +    const: default
> +
> +  clock-names:
> +    minItems: 1
> +    items:
> +      - const: pwm
> +      - const: capture

[Severity: Medium]
Can this rigid sequence for clock-names improperly reject valid capture-only
configurations during schema validation?

The driver selectively fetches clocks based on whether st,pwm-num-chan and
st,capture-num-chan are non-zero. If a hardware variant is configured solely
for input capture, it only needs the "capture" clock.

By defining an items array that starts with a constant of "pwm", the schema
mandates that the first or only clock name must be "pwm". Consequently, a
valid single-clock configuration providing just "capture" will be rejected by
the validation tools.

Would it make sense to use a more flexible schema construct like enum, anyOf,
or oneOf to allow either clock to be specified independently?

> +
> +  clocks:
> +    minItems: 1
> +    maxItems: 2

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260629-st-pwm-v5-1-a93f2bfec38c@gmail.com?part=1